Update checker #17
Merged
Update checker #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-richardson
force-pushed
the
update-checker
branch
from
f8d9cbd to
4d6601d
Compare
cfelde
reviewed
Nov 14, 2019
|
Latest commit refactors significantly and adds a (rather large) test. |
…nstead of using an update boolean
|
Please check out update4j |
josh-richardson
commented
Nov 25, 2019
Comment on lines
+4
to
7
| public static void main(String[] args) { | ||
|
|
||
| public static void main(String[]args) { | ||
|
|
||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Not strictly relevant to this PR, but fixes the issue where the generator generates Java with weird indentation.
|
This is ready for review, but should not be merged until I've got the version checking service up & running on k8s. |
cfelde
reviewed
Nov 25, 2019
…ersion.getversion
… into update-checker
|
This should now be ready to merge after review. |
|
Besides failing tests, LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for the update checker. Should write some tests before this all gets merged.