-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restruct config initialization #146
Conversation
@@ -128,7 +128,7 @@ func (c *Config) ChainsFromPath(path string) (map[string]*core.ProvableChain, st | |||
} | |||
|
|||
// Called to initialize the relayer.Chain types on Config | |||
func InitChains(ctx *Context, homePath string, debug bool) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function called by only this file.
return nil | ||
} | ||
|
||
func (ctx *Context) InitConfig(homePath string, debug bool) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Old function signature (c *Config) InitConfig(ctx *Context, ...)
is a bit confusing that c and ctx.Config should be same pointer or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dai1975 Great work overall, thank you! I've left some comments in the code. Could you please review them and make the necessary changes?
Signed-off-by: Daisuke Kanda <[email protected]>
eeaed5a
to
810fd56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dai1975 LGTM. Thank you!!
change config initialization structure to use logger in chain and/or prover init
before:
after: