Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use gogoprogo.jsobpb.Marshaler to output object #145

Merged
merged 1 commit into from
Aug 12, 2024
Merged

use gogoprogo.jsobpb.Marshaler to output object #145

merged 1 commit into from
Aug 12, 2024

Conversation

dai1975
Copy link
Contributor

@dai1975 dai1975 commented Aug 8, 2024 •
edited
Loading

In cmd/query.cmd, change outputting gogoproto object to use gogoproto.marshaler.MarshalToString.

And change docker-compose to docker compose in test script.

@dai1975 dai1975 requested a review from a team as a code owner August 8, 2024 05:36
@dai1975 dai1975 force-pushed the features/lo4326-output-json-marshal branch from 8694485 to 6d54839 Compare August 8, 2024 05:46
siburu
siburu approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@siburu siburu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dai1975 LGTM. Thank you!

@siburu siburu merged commit a10aff4 into hyperledger-labs:main Aug 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siburu siburu siburu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dai1975 @siburu