fix slog source attribute #144
Merged
+137
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daisuke Kanda <[email protected]>
siburu
reviewed
Jul 21, 2024
| func (rl *RelayLogger) Error(msg string, err error, otherArgs ...any) { | ||
| err = withstack.WithStackDepth(err, 1) | ||
| func (rl *RelayLogger) log(logLevel slog.Level, skipCallDepth int, msg string, args ...any) { | ||
| var pcs [1]uintptr |
There was a problem hiding this comment.
Don't you need to add the following?
if !l.Enabled(ctx, level) {
return
}
Ref: https://github.com/golang/go/blob/go1.22.5/src/log/slog/logger.go#L242-L244
There was a problem hiding this comment.
Right. It is fixed.
Signed-off-by: Daisuke Kanda <[email protected]>
dai1975
force-pushed
the
features/fix-slog-source
branch
from
cc7a240 to
f5fa37d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
RelayerLogger has wrapper functions to slog.log such as RelayerLogger.Error.
In case of application calls RelayerLogger.Error function, the source property of output log signs to RelayerLogger.Error function not caller of it.
Resolve
Passing upper of call stack to slog.
To perform it, I need to directly call
slog.Handler().Handle(ctx, record)function.others
Add test.
To simplify testing, I add writer paramerter to RelayerLog constructor.