Change behaviors of create client, connection, and channel commands. #138
+486
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dai1975
commented
Apr 13, 2024
dai1975
commented
- just exit with status 1 if config.json has id but that client/connection/channel is not exists.
- just exit with status 0 if config.json has id and that client/connection/channel is already opened.
dai1975
force-pushed
the
pr/id-in-config
branch
from
f66f8c1 to
7b5c80b
Compare
- just exit with status 1 if config.json has id but that client/connection/channel is not exists. - just exit with status 0 if config.json has id and that client/connection/channel is already opened. Signed-off-by: Daisuke Kanda <[email protected]>
dai1975
force-pushed
the
pr/id-in-config
branch
from
7b5c80b to
03f9219
Compare
Signed-off-by: Daisuke Kanda <[email protected]>
Signed-off-by: Daisuke Kanda <[email protected]>
siburu
reviewed
Apr 19, 2024
siburu
reviewed
Apr 19, 2024
Signed-off-by: Daisuke Kanda <[email protected]>
Signed-off-by: Daisuke Kanda <[email protected]>
Signed-off-by: Daisuke Kanda <[email protected]>
…ts in e2e test Signed-off-by: Daisuke Kanda <[email protected]>
Signed-off-by: Daisuke Kanda <[email protected]>
dai1975
force-pushed
the
pr/id-in-config
branch
from
dabc39f to
09f13c4
Compare
Signed-off-by: Daisuke Kanda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.