Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ibc-go to v8 #134

Merged
merged 19 commits into from
Apr 2, 2024
Merged

Update ibc-go to v8 #134

merged 19 commits into from
Apr 2, 2024

Conversation

dongrie
Copy link
Contributor

@dongrie dongrie commented Jan 26, 2024 •
edited
Loading

Made a series of modifications to support ibc-go/v8

@dongrie dongrie marked this pull request as ready for review February 2, 2024 04:08
@dongrie dongrie requested a review from a team as a code owner February 2, 2024 04:08
@dongrie
Update to ibc-go-v8
fd8b75c 
Signed-off-by: Dongri Jin <[email protected]>
@dongrie
Add AppModules
33ec3a8 
Signed-off-by: Dongri Jin <[email protected]>
@dongrie
Fix parseMsgEventLogs
e9bf745 
Signed-off-by: Dongri Jin <[email protected]>
@dongrie
Remote WithTxConfig
312c1e7 
Signed-off-by: Dongri Jin <[email protected]>
@dongrie
Fix signmode
5070bf8 
Signed-off-by: Dongri Jin <[email protected]>
@dongrie
Fix simapp
592d826 
Signed-off-by: Dongri Jin <[email protected]>
@dongrie
Fix txConfig
fd9e558 
Signed-off-by: Dongri Jin <[email protected]>
@dongrie dongrie changed the title Update to ibc-go-v8 Update ibc-go to v8 Feb 8, 2024
@dongrie
Use ibc-mock-clinet v0.3.4
ac15be5 
Signed-off-by: Dongri Jin <[email protected]>
@dongrie dongrie force-pushed the ibc-go-v8 branch 2 times, most recently from 766eff7 to ac15be5 Compare March 6, 2024 02:54
@dongrie
Use sdk context
a0ff8fe 
Signed-off-by: Dongri Jin <[email protected]>
siburu
siburu reviewed Mar 8, 2024
View reviewed changes
Copy link
Contributor

@siburu siburu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dongrie Sorry for late review. I put some comments.

chains/tendermint/msg.go Outdated Show resolved Hide resolved
chains/tendermint/query.go Outdated Show resolved Hide resolved
tests/chains/tendermint/Dockerfile Outdated Show resolved Hide resolved
tests/chains/tendermint/simapp/export.go Show resolved Hide resolved
tests/chains/tendermint/simapp/export.go Outdated Show resolved Hide resolved
tests/chains/tendermint/simapp/simd/cmd/root.go Outdated Show resolved Hide resolved
tests/chains/tendermint/simapp/types.go Outdated Show resolved Hide resolved
tests/chains/tendermint/simapp/app.go Outdated Show resolved Hide resolved
dongrie added 2 commits March 10, 2024 16:34
@dongrie
* Remove types from simp
94bf3a5 
* Fix msgIndex logic


Signed-off-by: Dongri Jin <[email protected]>
@dongrie
Fix simapp
afb578e 
Signed-off-by: Dongri Jin <[email protected]>
@dongrie dongrie requested a review from siburu March 15, 2024 11:50
siburu
siburu reviewed Mar 19, 2024
View reviewed changes
chains/tendermint/msg.go Outdated Show resolved Hide resolved
dongrie added 4 commits March 21, 2024 11:21
@dongrie
Reduce the diff
706744e 
Signed-off-by: Dongri Jin <[email protected]>
@dongrie
Remove homePath parameter
1fc7fa7 
Signed-off-by: Dongri Jin <[email protected]>
@dongrie
Reduce the diff
b7dcf27 
Signed-off-by: Dongri Jin <[email protected]>
@dongrie
Fix msgIndexOf func
68732a2 
Signed-off-by: Dongri Jin <[email protected]>
@dongrie dongrie requested a review from siburu March 21, 2024 05:55
dongrie added 2 commits March 22, 2024 09:21
@dongrie
Add upgrades.go
560229e 
Signed-off-by: Dongri Jin <[email protected]>
@dongrie
Fix add genesis accounts
fc6d174 
Signed-off-by: Dongri Jin <[email protected]>
siburu
siburu reviewed Mar 31, 2024
View reviewed changes
go.mod Outdated
github.com/spf13/cobra v1.7.0
github.com/spf13/viper v1.16.0
go.opentelemetry.io/otel v1.16.0
go.opentelemetry.io/otel/exporters/prometheus v0.39.0
go.opentelemetry.io/otel/metric v1.16.0
go.opentelemetry.io/otel/sdk/metric v0.39.0
golang.org/x/exp v0.0.0-20230515195305-f3d0a9c9a5cc
golang.org/x/sync v0.1.0
golang.org/x/exp v0.0.0-20231006140011-7918f672742d
Copy link
Contributor

@siburu siburu Mar 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dongrie Can we switch from golang.org/x/exp/slog to log/slog in the standard library?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change golang.org/x/exp/slog to log/slog
fdaee6c

@siburu
Copy link
Contributor

siburu commented Mar 31, 2024

@dongrie Could you also update simapp/README.md ?

@dongrie
Fix simapp/README.md
1020f7f 
Signed-off-by: Dongri Jin <[email protected]>
@dongrie
Copy link
Contributor Author

dongrie commented Apr 2, 2024

@dongrie Could you also update simapp/README.md ?

Updated simapp/README.md
1020f7f

@dongrie dongrie requested a review from siburu April 2, 2024 01:38
siburu
siburu approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@siburu siburu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dongrie LGTM. Thank you!

@siburu siburu merged commit b270f8f into hyperledger-labs:main Apr 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siburu siburu siburu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dongrie @siburu