Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the direction of CheckRefreshRequired #123

Merged
merged 1 commit into from
Nov 13, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/naive-strategy.go
Original file line number Diff line number Diff line change
Expand Up @@ -504,14 +504,14 @@ func (st *NaiveStrategy) UpdateClients(src, dst *ProvableChain, rpForRecv, rpFor
// check if LC refresh is needed
if !needsUpdateForSrc && doRefresh {
var err error
needsUpdateForSrc, err = src.CheckRefreshRequired(dst)
needsUpdateForSrc, err = dst.CheckRefreshRequired(src)
if err != nil {
return nil, fmt.Errorf("failed to check if the LC on the src chain needs to be refreshed: %v", err)
}
}
if !needsUpdateForDst && doRefresh {
var err error
needsUpdateForDst, err = dst.CheckRefreshRequired(src)
needsUpdateForDst, err = src.CheckRefreshRequired(dst)
if err != nil {
return nil, fmt.Errorf("failed to check if the LC on the dst chain needs to be refreshed: %v", err)
}
Expand Down
Loading