Optimize Relay #108
Merged
Optimize Relay #108
+439
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dongrie is this PR ready for review? |
dongrie
force-pushed
the
optimize-relay
branch
from
3e6da80 to
9c96b8c
Compare
|
@siburu Change to ready for review |
siburu
reviewed
Oct 24, 2023
dongrie
force-pushed
the
optimize-relay
branch
from
cc48cb2 to
f005205
Compare
siburu
reviewed
Nov 21, 2023
siburu
reviewed
Nov 24, 2023
Signed-off-by: Dongri Jin <[email protected]>
Signed-off-by: Dongri Jin <[email protected]>
Signed-off-by: Dongri Jin <[email protected]>
Signed-off-by: Dongri Jin <[email protected]>
Signed-off-by: Dongri Jin <[email protected]>
* Fix start time variable * Change relay parameter Signed-off-by: Dongri Jin <[email protected]>
Signed-off-by: Dongri Jin <[email protected]>
Signed-off-by: Dongri Jin <[email protected]>
Signed-off-by: Dongri Jin <[email protected]>
dongrie
force-pushed
the
optimize-relay
branch
from
90087f6 to
80660e3
Compare
Signed-off-by: Dongri Jin <[email protected]>
siburu
reviewed
Dec 4, 2023
siburu
reviewed
Dec 5, 2023
Signed-off-by: Dongri Jin <[email protected]>
Signed-off-by: Dongri Jin <[email protected]>
siburu
reviewed
Dec 5, 2023
siburu
reviewed
Dec 5, 2023
siburu
reviewed
Dec 5, 2023
siburu
reviewed
Dec 5, 2023
siburu
reviewed
Dec 5, 2023
siburu
reviewed
Dec 5, 2023
siburu
reviewed
Dec 5, 2023
Signed-off-by: Dongri Jin <[email protected]>
Signed-off-by: Dongri Jin <[email protected]>
Signed-off-by: Dongri Jin <[email protected]>
Signed-off-by: Dongri Jin <[email protected]>
Signed-off-by: Dongri Jin <[email protected]>
|
Fixed test-service |
Use eventHeight Signed-off-by: Dongri Jin <[email protected]>
Signed-off-by: Dongri Jin <[email protected]>
siburu
reviewed
Jan 22, 2024
chains/tendermint/query.go
Outdated
| } else { | ||
| counterpartyCtx = core.NewQueryContext(context.TODO(), counterpartyH.GetHeight()) | ||
| } | ||
|
|
||
| seqs, err := counterparty.QueryUnreceivedPackets(counterpartyCtx, packets.ExtractSequenceList()) | ||
| if err != nil { | ||
| return nil, err | ||
| return nil, fmt.Errorf("failed to counterparty query unreceived packets: %w height: %v", err, counterpartyCtx.Height()) |
There was a problem hiding this comment.
"failed to query counterparty for unreceived packets: error=%w, height=%v"
Please apply the same changes to similar comments throughout this file.
There was a problem hiding this comment.
Fixed error message
72e4d88
There was a problem hiding this comment.
@dongrie Please apply the same changes to similar comments throughout this file...
There was a problem hiding this comment.
Fixed error messages
72e4d88
* Fix check src, dst timestamp * Fix test case comments Signed-off-by: Dongri Jin <[email protected]>
Signed-off-by: Dongri Jin <[email protected]>
siburu
reviewed
Jan 30, 2024
chains/tendermint/query.go
Outdated
| } else { | ||
| counterpartyCtx = core.NewQueryContext(context.TODO(), counterpartyH.GetHeight()) | ||
| } | ||
|
|
||
| seqs, err := counterparty.QueryUnreceivedAcknowledgements(counterpartyCtx, packets.ExtractSequenceList()) | ||
| if err != nil { | ||
| return nil, err | ||
| return nil, fmt.Errorf("failed to counterparty query unreceived acknowledgements: error=%w height=%v", err, counterpartyCtx.Height()) |
There was a problem hiding this comment.
@dongrie failed to query counterparty for unreceived ...
Signed-off-by: Dongri Jin <[email protected]>
siburu
reviewed
Jan 31, 2024
chains/tendermint/query.go
Outdated
| } else { | ||
| counterpartyCtx = core.NewQueryContext(context.TODO(), counterpartyH.GetHeight()) | ||
| } | ||
|
|
||
| seqs, err := counterparty.QueryUnreceivedAcknowledgements(counterpartyCtx, packets.ExtractSequenceList()) | ||
| if err != nil { | ||
| return nil, err | ||
| return nil, fmt.Errorf("failed to query counterparty for unreceived: error=%w height=%v", err, counterpartyCtx.Height()) |
Signed-off-by: Dongri Jin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimized execution interval of relay service