Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time track #107

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Add time track #107

merged 2 commits into from
Sep 22, 2023

Conversation

dongrie
Copy link
Contributor

@dongrie dongrie commented Sep 14, 2023

Add time track

{"time":"2023-09-14T10:25:00.919158+09:00","level":"INFO","source":{"function":"github.com/hyperledger-labs/yui-relayer/log.(*RelayLogger).TimeTrack","file":"/Users/dongri.jin/go/src/github.com/dongrie/yui-relayer-time-track/log/slog.go","line":182},"msg":"time track","module":"ethereum.chain","name":"findRecvPacketEvents","elapsed":10582031}
{"time":"2023-09-14T10:25:00.921196+09:00","level":"INFO","source":{"function":"github.com/hyperledger-labs/yui-relayer/log.(*RelayLogger).TimeTrack","file":"/Users/dongri.jin/go/src/github.com/dongrie/yui-relayer-time-track/log/slog.go","line":182},"msg":"time track","module":"ethereum.chain","name":"findRecvPacketEvents","elapsed":12625927}

{"time":"2023-09-14T10:25:00.934499+09:00","level":"INFO","source":{"function":"github.com/hyperledger-labs/yui-relayer/log.(*RelayLogger).TimeTrack","file":"/Users/dongri.jin/go/src/github.com/dongrie/yui-relayer-time-track/log/slog.go","line":182},"msg":"time track","module":"ethereum.chain","name":"QueryUnreceivedAcknowledgements","elapsed":356}
{"time":"2023-09-14T10:25:00.936148+09:00","level":"INFO","source":{"function":"github.com/hyperledger-labs/yui-relayer/log.(*RelayLogger).TimeTrack","file":"/Users/dongri.jin/go/src/github.com/dongrie/yui-relayer-time-track/log/slog.go","line":182},"msg":"time track","module":"ethereum.chain","name":"QueryUnfinalizedRelayAcknowledgements","elapsed":27791926}
{"time":"2023-09-14T10:25:00.941646+09:00","level":"INFO","source":{"function":"github.com/hyperledger-labs/yui-relayer/log.(*RelayLogger).TimeTrack","file":"/Users/dongri.jin/go/src/github.com/dongrie/yui-relayer-time-track/log/slog.go","line":182},"msg":"time track","module":"ethereum.chain","name":"QueryUnreceivedAcknowledgements","elapsed":3310680}

Signed-off-by: Dongri Jin <[email protected]>
@dongrie dongrie requested a review from a team as a code owner September 14, 2023 07:33
@siburu
Copy link
Contributor

siburu commented Sep 20, 2023

@dongrie Seems perfect. Thank you!
I'd like to ask one more question, or, want to request one more feature.
Can we add src/dst height information to the client/connection/channel loggers?
I notice that most of use cases of logs need height information.

@dongrie
Copy link
Contributor Author

dongrie commented Sep 21, 2023

@siburu
0c705d4
Add height to log

Signed-off-by: Dongri Jin <[email protected]>
@dongrie
Copy link
Contributor Author

dongrie commented Sep 22, 2023

Revert height commit, Add WithChain logger

Copy link
Contributor

@siburu siburu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!!

@siburu siburu merged commit d1346bc into hyperledger-labs:main Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants