Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge commits from main in attestation-dev branch #507

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Conversation

bvavala
Copy link
Member

@bvavala bvavala commented Nov 5, 2024

No description provided.

bvavala and others added 3 commits October 22, 2024 10:01
Signed-off-by: Bruno Vavala <[email protected]>
* Updates to github workflows for PDO

*EXPERIMENTAL* -- new github workflows will only be
visible and runnable when they are attached to the
main branch. this commit will enable further testing.

Expand the github workflows associated with the PDO repository. The
old "ci" workflow has been moved to a workflow called "full_test" and
is used as a condition for merge of PRs. It will no longer be run on
every push but only on PR creation.

Add a "configured_test" workflow that can be dispatched on
demand. This workflow allows for different build and run parameters to
be set interactively.

Add a "build_docker" workflow that will attempt to build docker images
pdo_client, pdo_services and pdo_ccf when a PR is merged
successfully. This workflow can also be dispatched interactively.

Signed-off-by: Mic Bowman <[email protected]>

* add documentation to workflows

Signed-off-by: Mic Bowman <[email protected]>

---------

Signed-off-by: Mic Bowman <[email protected]>
Two issues... first, moved the docker workflow to be triggered
exclusively through interactive request. The policy for automated
triggering can be determined at a later time.

Second, fixed a couple bugs in the docker workflow. Now that the
workflow is a part of the main branch, debugging is far easier.

Note that this is been tested on a personal repository but not
on an organizational repository such as hyperledger.

Signed-off-by: Mic Bowman <[email protected]>
@bvavala bvavala requested a review from cmickeyb November 5, 2024 20:50
@cmickeyb cmickeyb merged commit 4f44384 into attestation-dev Nov 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants