Add a lock around the block manager start #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmickeyb
force-pushed
the
mic.nov01.block_manager
branch
from
099c2ac to
2c2b045
Compare
Signed-off-by: Mic Bowman <[email protected]>
cmickeyb
force-pushed
the
mic.nov01.block_manager
branch
from
2c2b045 to
e148618
Compare
g2flyer
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
lgtm, certainly in presence of multi-threaded consumers of block_store_manager that lock is required to protected the global object (just didn't realize before this PR that we do have multi-threaded code, so never reviewed from a concurrency control perspective)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.