Move to standard tools for in-memory contract object cache #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transition from very simple cache for contract objects to a more standard cache implementation from cachetools. The transition enables both more functionality (explicit client control of when the cache is flushed) and better behavior (automatic flushing of older contract objects). Several other clean ups of imports and other unused variables. Signed-off-by: Mic Bowman <[email protected]>
g2flyer
approved these changes
May 8, 2024
bvavala
reviewed
May 9, 2024
| # expiration from the cache really means that we want the | ||
| # contract re-read, so force any expired contracts out of | ||
| # the cache before we read it | ||
| __get_contract__.cache.expire() |
There was a problem hiding this comment.
Doesn't this effectively force cache expiration on each get, so you don't really get the benefits of having a cache?
There was a problem hiding this comment.
no. if you read the documentation on cache tools the behavior is more or less what i described. expire only drops those entries that have timed out. all other entries will remain. clear is the operation to drop all cache entries no matter the timing.
bvavala
approved these changes
May 9, 2024
prakashngit
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transition from very simple cache for contract objects to a more standard cache implementation from cachetools. The transition enables both more functionality (explicit client control of when the cache is flushed) and better behavior (automatic flushing of older contract objects).
Several other clean ups of imports and other unused variables.