Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make small config changes #76

Conversation

jrayback
Copy link
Contributor

Make small config changes:

  • Remove 'version' tag from docker-compose.yml since it is no longer supported.
  • Update .gitignore to ignore runtime files and directories.

Copy link
Contributor

@2byrds 2byrds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thank you Jonathan!

@2byrds
Copy link
Contributor

2byrds commented Oct 24, 2024

@jrayback it looks like the pytest check has failed. Also commits need to be signed to pass the DCO check

@jrayback jrayback force-pushed the jrayback_241023_make-small-config-changes branch from d648d52 to f9fe744 Compare October 24, 2024 17:22
@jrayback
Copy link
Contributor Author

@2byrds , I've signed both commits. It looks like checks passed.

@2byrds 2byrds merged commit ce04c0e into hyperledger-labs:main Oct 24, 2024
3 of 4 checks passed
@jrayback jrayback deleted the jrayback_241023_make-small-config-changes branch October 25, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants