Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform to/from did:web document #20

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

peacekeeper
Copy link
Contributor

With this change, the DID document on the server is transformed to a did:web DID document (to be compatible with the did:web method), and when resolving it, it is transformed back to a did:webs DID document.

See corresponding spec change: trustoverip/tswg-did-method-webs-specification#40

@peacekeeper peacekeeper requested a review from 2byrds October 6, 2023 22:31
Copy link
Contributor

@2byrds 2byrds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As I'm reviewing the code, it is getting harder to visually verify the string literals. What do you think introducing constants for things like did:web vs did:webs, verificationMethod, and properties like 'controller', 'id', etc?

@2byrds 2byrds merged commit d3d5b84 into hyperledger-labs:main Oct 6, 2023
@peacekeeper peacekeeper deleted the to-from-did-web branch October 8, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants