Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(multisig)!: move from triggers to custom instructions #5217

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

refactor(multisig)!: move from triggers to custom instructions #5217

wants to merge 20 commits into from
+971 −1,305

Commits on Nov 5, 2024

  1. refactor!: move multisig logics to custom instructions 

    BREAKING CHANGES:

- (api-changes) `MultisigRegister` `MultisigPropose` `MultisigApprove` custom instructions

Signed-off-by: Shunkichi Sato <[email protected]>
    @s8sato
    s8sato committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    e37bb4d View commit details
    Browse the repository at this point in the history

  2. fix: don't continue to grant a role on failing to register the role 

    Signed-off-by: Shunkichi Sato <[email protected]>
    @s8sato
    s8sato committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    00ec667 View commit details
    Browse the repository at this point in the history

  3. docs: fix doc test 

    Signed-off-by: Shunkichi Sato <[email protected]>
    @s8sato
    s8sato committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    a4ac5b0 View commit details
    Browse the repository at this point in the history

  4. chore: remove CanRegisterAnyTrigger CanUnregisterAnyTrigger permi… 

    …ssions

Signed-off-by: Shunkichi Sato <[email protected]>
    @s8sato
    s8sato committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    657d3ad View commit details
    Browse the repository at this point in the history

  5. refactor: don't branch into visit and execute until leaf instruct… 

    …ions

Signed-off-by: Shunkichi Sato <[email protected]>
    @s8sato
    s8sato committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    b158c59 View commit details
    Browse the repository at this point in the history

  6. refactor: clone and drop executor instance on recursive execution 

    Signed-off-by: Shunkichi Sato <[email protected]>
    @s8sato
    s8sato committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    4eedd61 View commit details
    Browse the repository at this point in the history

  7. fix: don't just execute arbitrary approved instructions 

    Signed-off-by: Shunkichi Sato <[email protected]>
    @s8sato
    s8sato committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    da8e7fb View commit details
    Browse the repository at this point in the history

  8. fix: propagate executor verdict 

    Signed-off-by: Shunkichi Sato <[email protected]>
    @s8sato
    s8sato committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    f54bd6e View commit details
    Browse the repository at this point in the history

  9. review: address up to #issuecomment-2453963837 

    Signed-off-by: Shunkichi Sato <[email protected]>
    @s8sato
    s8sato committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    d75e932 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. docs: Update readmes (hyperledger-iroha#5219) 

    Signed-off-by: Ekaterina Mekhnetsova <[email protected]>
    @outoftardis @s8sato
    outoftardis authored and s8sato committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    0e8f7e6 View commit details
    Browse the repository at this point in the history

  2. review: rename to visit_custom_instructions 

    Signed-off-by: Shunkichi Sato <[email protected]>
    @s8sato
    s8sato committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    3c1888d View commit details
    Browse the repository at this point in the history

  3. review: move to `{iroha_executor::default, iroha_executor_data_model}… 

    …::custom::multisig`

Signed-off-by: Shunkichi Sato <[email protected]>
    @s8sato
    s8sato committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    bc1d497 View commit details
    Browse the repository at this point in the history

  4. review: minor updates since #pullrequestreview-2414675315 

    Signed-off-by: Shunkichi Sato <[email protected]>
    @s8sato
    s8sato committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    bdd2a09 View commit details
    Browse the repository at this point in the history

  5. review: submit a new account with metadata filled 

    Signed-off-by: Shunkichi Sato <[email protected]>
    @s8sato
    s8sato committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    255782e View commit details
    Browse the repository at this point in the history

  6. Revert "review: submit a new account with metadata filled" 

    This reverts commit 255782e.

Signed-off-by: Shunkichi Sato <[email protected]>
    @s8sato
    s8sato committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    b0208cc View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into refactor/4930/custom_instructions 

    Signed-off-by: Shunkichi Sato <[email protected]>
    @s8sato
    s8sato committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    e95f743 View commit details
    Browse the repository at this point in the history

  8. fix: prevent a double grant to the registrant who is also a signatory 

    Signed-off-by: Shunkichi Sato <[email protected]>
    @s8sato
    s8sato committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    45b24d9 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. review: minor updates since #pullrequestreview-2418103555 

    Signed-off-by: Shunkichi Sato <[email protected]>
    @s8sato
    s8sato committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    e0a96f4 View commit details
    Browse the repository at this point in the history

  2. review: nonzero quorum and transaction_ttl_ms 

    Signed-off-by: Shunkichi Sato <[email protected]>
    @s8sato
    s8sato committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    183ff26 View commit details
    Browse the repository at this point in the history

  3. review: replace host.submit with executor.visit_* 

    Signed-off-by: Shunkichi Sato <[email protected]>
    @s8sato
    s8sato committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    70d51d0 View commit details
    Browse the repository at this point in the history