-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor]: update iroha_schema_derive
to use syn 2.0
#3759
Merged
appetrosyan
merged 2 commits into
hyperledger-iroha:iroha2-dev
from
DCNick3:syn2-iroha-schema
Aug 14, 2023
Merged
[refactor]: update iroha_schema_derive
to use syn 2.0
#3759
appetrosyan
merged 2 commits into
hyperledger-iroha:iroha2-dev
from
DCNick3:syn2-iroha-schema
Aug 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
label
Jul 28, 2023
Pull Request Test Coverage Report for Build 5856040680
💛 - Coveralls |
DCNick3
force-pushed
the
syn2-iroha-schema
branch
from
July 28, 2023 14:11
c0e0be0
to
d06c3fb
Compare
appetrosyan
suggested changes
Jul 28, 2023
version/derive/tests/ui_fail/unknown_field_in_version_attribute.stderr
Outdated
Show resolved
Hide resolved
appetrosyan
reviewed
Jul 28, 2023
appetrosyan
suggested changes
Jul 28, 2023
DCNick3
force-pushed
the
syn2-iroha-schema
branch
2 times, most recently
from
August 1, 2023 06:43
f9f8407
to
aa575ba
Compare
DCNick3
requested review from
s8sato,
mversic,
SamHSmith,
QuentinI,
outoftardis,
ilchu,
pesterev,
Erigara and
0x009922
as code owners
August 1, 2023 08:15
DCNick3
force-pushed
the
syn2-iroha-schema
branch
from
August 2, 2023 07:53
aa575ba
to
5f14413
Compare
Arjentix
reviewed
Aug 2, 2023
DCNick3
force-pushed
the
syn2-iroha-schema
branch
2 times, most recently
from
August 14, 2023 10:16
9079449
to
f7059bb
Compare
appetrosyan
approved these changes
Aug 14, 2023
appetrosyan
approved these changes
Aug 14, 2023
Arjentix
approved these changes
Aug 14, 2023
Also parse attributes with `darling` and handle errors with `manyhow` Signed-off-by: Nikita Strygin <[email protected]>
…representation of schema Signed-off-by: Nikita Strygin <[email protected]>
appetrosyan
force-pushed
the
syn2-iroha-schema
branch
from
August 14, 2023 13:01
f7059bb
to
1662b4d
Compare
appetrosyan
merged commit Aug 14, 2023
24b8b03
into
hyperledger-iroha:iroha2-dev
5 of 7 checks passed
This was referenced Sep 21, 2023
Closed
This was referenced Sep 28, 2023
Migrate
iroha_smart_contract_derive
, iroha_executor_derive
and iroha_trigger_derive
to syn 2.0
#3934
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also parse attributes with
darling
and handle errors withmanyhow
Description
This is continuation of work started in #3727, touching on
iroha_schema_derive
.There was an unused API in
TypeId
derive:#[type_id(bound = "...")]
, I removed support for it for now.Benefits
Same as before: less code, better error messages.
Checklist
iroha_schema_derive
crate