Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] #3075: Panic on invalid tx in genesis. #3538

Merged
merged 1 commit into from
May 29, 2023
Merged

[fix] #3075: Panic on invalid tx in genesis. #3538

merged 1 commit into from
May 29, 2023

Conversation

SamHSmith
Copy link
Contributor

@SamHSmith SamHSmith commented May 29, 2023 •
edited by 6r1d
Loading

Description

Linked issue

Closes #3075

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label May 29, 2023
mversic
mversic approved these changes May 29, 2023
View reviewed changes
core/src/sumeragi/main_loop.rs Show resolved Hide resolved
Erigara
Erigara approved these changes May 29, 2023
View reviewed changes
Copy link
Contributor

@Erigara Erigara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i think we should test for this behavior (probably in the separate PR).

@SamHSmith SamHSmith merged commit bf63c6e into hyperledger-iroha:iroha2-dev May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mversic mversic mversic approved these changes

@Erigara Erigara Erigara approved these changes

@s8sato s8sato Awaiting requested review from s8sato

@appetrosyan appetrosyan Awaiting requested review from appetrosyan

@Arjentix Arjentix Awaiting requested review from Arjentix

@QuentinI QuentinI Awaiting requested review from QuentinI

@outoftardis outoftardis Awaiting requested review from outoftardis

@ilchu ilchu Awaiting requested review from ilchu

@pesterev pesterev Awaiting requested review from pesterev

@0x009922 0x009922 Awaiting requested review from 0x009922

Assignees

@SamHSmith SamHSmith

@Erigara Erigara

@mversic mversic

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SamHSmith @Erigara @mversic