-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] #2456: Make genesis block unlimited #3074
Merged
Erigara
merged 1 commit into
hyperledger-iroha:iroha2-dev
from
Erigara:unlimited_genesis
Jan 24, 2023
Merged
[fix] #2456: Make genesis block unlimited #3074
Erigara
merged 1 commit into
hyperledger-iroha:iroha2-dev
from
Erigara:unlimited_genesis
Jan 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erigara
added
Bug
Something isn't working
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
labels
Jan 23, 2023
Erigara
requested review from
s8sato,
appetrosyan,
mversic,
Arjentix,
SamHSmith,
QuentinI,
outoftardis,
ilchu and
pesterev
as code owners
January 23, 2023 10:29
Erigara
force-pushed
the
unlimited_genesis
branch
from
January 23, 2023 10:47
bb57123
to
af61ca8
Compare
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #3074 +/- ##
==============================================
+ Coverage 62.33% 64.56% +2.23%
==============================================
Files 169 171 +2
Lines 31218 33075 +1857
==============================================
+ Hits 19459 21356 +1897
+ Misses 11759 11719 -40
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mversic
requested changes
Jan 23, 2023
Erigara
force-pushed
the
unlimited_genesis
branch
from
January 23, 2023 13:11
af61ca8
to
fff89c2
Compare
mversic
previously approved these changes
Jan 23, 2023
Erigara
force-pushed
the
unlimited_genesis
branch
from
January 23, 2023 13:47
fff89c2
to
24a73b8
Compare
mversic
previously approved these changes
Jan 23, 2023
appetrosyan
previously approved these changes
Jan 23, 2023
Erigara
force-pushed
the
unlimited_genesis
branch
from
January 24, 2023 07:55
24a73b8
to
de23029
Compare
Signed-off-by: Shanin Roman <[email protected]>
Erigara
force-pushed
the
unlimited_genesis
branch
from
January 24, 2023 07:56
de23029
to
e0e7fe8
Compare
appetrosyan
approved these changes
Jan 24, 2023
mversic
reviewed
Jan 24, 2023
mversic
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shanin Roman [email protected]
Description of the Change
Issue
Closes #2456.
Benefits
Provide possibility for users to submit large genesis which should play well with block store merge tool.
Possible Drawbacks
User can try to submit too large genesis which would cause issues during network transfer.
Usage Examples or Tests