Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] #3053: Fix clippy lints #3054

Merged
merged 18 commits into from
Jan 11, 2023

Conversation

Arjentix
Copy link
Contributor

Description of the Change

Fix some clippy and cargo check lints

Issue

Benefits

No Mac M1 users have no lint errors hell

Possible Drawbacks

None

Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix Arjentix added iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality labels Jan 10, 2023
@Arjentix Arjentix self-assigned this Jan 10, 2023
@Arjentix Arjentix changed the title Fix lints [refactor] #3053: Fix clippy lints Jan 10, 2023
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #3054 (6b58207) into iroha2-dev (a4d5c9f) will increase coverage by 1.24%.
The diff coverage is 65.44%.

@@              Coverage Diff               @@
##           iroha2-dev    #3054      +/-   ##
==============================================
+ Coverage       62.33%   63.58%   +1.24%     
==============================================
  Files             169      170       +1     
  Lines           31218    32791    +1573     
==============================================
+ Hits            19459    20849    +1390     
- Misses          11759    11942     +183     
Impacted Files Coverage Δ
cli/src/main.rs 1.09% <0.00%> (ø)
cli/src/torii/mod.rs 27.65% <ø> (ø)
cli/src/torii/utils.rs 75.00% <0.00%> (-9.85%) ⬇️
client_cli/src/main.rs 0.24% <0.00%> (-0.01%) ⬇️
config/base/src/lib.rs 91.57% <ø> (+55.21%) ⬆️
config/src/lib.rs 33.33% <ø> (ø)
config/src/path.rs 0.00% <0.00%> (ø)
core/src/smartcontracts/isi/block.rs 85.71% <ø> (-3.18%) ⬇️
.../src/smartcontracts/isi/permissions/combinators.rs 45.94% <ø> (ø)
core/src/smartcontracts/isi/permissions/roles.rs 53.22% <ø> (ø)
... and 138 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Erigara Erigara self-assigned this Jan 11, 2023
Erigara
Erigara previously approved these changes Jan 11, 2023
Copy link
Contributor

@Erigara Erigara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

data_model/src/transaction.rs Outdated Show resolved Hide resolved
mversic
mversic previously approved these changes Jan 11, 2023
config/src/path.rs Show resolved Hide resolved
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix Arjentix dismissed stale reviews from mversic and Erigara via 6b58207 January 11, 2023 10:27
@Arjentix Arjentix merged commit 2e1db47 into hyperledger-iroha:iroha2-dev Jan 11, 2023
@Arjentix Arjentix deleted the fix_lints branch January 11, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants