-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] #3053: Fix clippy lints #3054
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Arjentix
added
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Refactor
Improvement to overall code quality
labels
Jan 10, 2023
Arjentix
requested review from
s8sato,
appetrosyan,
mversic,
SamHSmith,
QuentinI,
outoftardis,
ilchu,
pesterev and
Erigara
as code owners
January 10, 2023 21:26
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #3054 +/- ##
==============================================
+ Coverage 62.33% 63.58% +1.24%
==============================================
Files 169 170 +1
Lines 31218 32791 +1573
==============================================
+ Hits 19459 20849 +1390
- Misses 11759 11942 +183
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Erigara
previously approved these changes
Jan 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mversic
previously approved these changes
Jan 11, 2023
Signed-off-by: Daniil Polyakov <[email protected]>
Erigara
approved these changes
Jan 11, 2023
mversic
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Refactor
Improvement to overall code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fix some clippy and
cargo check
lintsIssue
Benefits
No Mac M1 users have no lint errors hell
Possible Drawbacks
None