-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] #2963: Queue remove transactions correctly #3035
Conversation
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #3035 +/- ##
==============================================
+ Coverage 62.33% 63.55% +1.22%
==============================================
Files 169 170 +1
Lines 31218 32864 +1646
==============================================
+ Hits 19459 20886 +1427
- Misses 11759 11978 +219
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
something's wrong with issue id in the title. It actually references a PR instead. Probably a github issue? But even the |
oh, sure |
f81910e
to
7898114
Compare
2b18ee8
to
3e1fb30
Compare
3ca0ffe
to
a1e6e42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking so long, wanted to make sure I understood what's going on.
Signed-off-by: Shanin Roman <[email protected]>
Signed-off-by: Shanin Roman <[email protected]>
Description of the Change
Issue
Closes #2963.
Benefits
/status
response.Possible Drawbacks
None.
Usage Examples or Tests [optional]
Queue size field in the status response:
Alternate Designs [optional]
Multi-signatures are still not handled correctly by the queue, i would suggest fix this in the separate PR.