Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] #2153: Fix coverage #2154

Merged
merged 12 commits into from
Apr 28, 2022
Merged

Conversation

s8sato
Copy link
Contributor

@s8sato s8sato commented Apr 27, 2022

Description of the Change

  1. Resolve the toolchain differences around llvm-tools-preview

  2. Move the coverage tool from grcov to cargo-llvm-cov ?

Issue

Benefits

  1. Fix the CI failure

Possible Drawbacks

  1. Not sure how long cargo-llvm-cov will be maintained

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Apr 27, 2022
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #2154 (cf48df6) into iroha2-dev (a8e011a) will increase coverage by 78.84%.
The diff coverage is n/a.

❗ Current head cf48df6 differs from pull request most recent head 502289e. Consider uploading reports for the commit 502289e to get more accurate results

@@               Coverage Diff               @@
##           iroha2-dev    #2154       +/-   ##
===============================================
+ Coverage            0   78.84%   +78.84%     
===============================================
  Files               0      125      +125     
  Lines               0    22308    +22308     
===============================================
+ Hits                0    17588    +17588     
- Misses              0     4720     +4720     
Impacted Files Coverage Δ
telemetry/src/futures.rs 25.45% <0.00%> (ø)
data_model/src/pagination.rs 77.94% <0.00%> (ø)
data_model/src/events/mod.rs 49.09% <0.00%> (ø)
data_model/src/isi.rs 87.98% <0.00%> (ø)
...ions_validators/src/private_blockchain/register.rs 40.90% <0.00%> (ø)
client/src/config.rs 69.35% <0.00%> (ø)
data_model/src/events/data/events.rs 38.80% <0.00%> (ø)
core/src/smartcontracts/isi/tx.rs 40.00% <0.00%> (ø)
cli/src/torii/routing.rs 82.29% <0.00%> (ø)
telemetry/src/config.rs 64.70% <0.00%> (ø)
... and 115 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8e011a...502289e. Read the comment docs.

@s8sato s8sato marked this pull request as draft April 27, 2022 09:35
@s8sato s8sato changed the title [fix] #2153: Move the code coverage to cargo-llvm-cov [ci] #2153: Move the code coverage to cargo-llvm-cov Apr 27, 2022
@s8sato s8sato changed the title [ci] #2153: Move the code coverage to cargo-llvm-cov [ci] #2153: Fix coverage Apr 27, 2022
@s8sato s8sato marked this pull request as ready for review April 27, 2022 16:03
@s8sato s8sato marked this pull request as draft April 27, 2022 16:54
@appetrosyan appetrosyan marked this pull request as ready for review April 28, 2022 05:45
@appetrosyan appetrosyan enabled auto-merge (squash) April 28, 2022 14:49
@appetrosyan appetrosyan merged commit 7e338a5 into hyperledger-iroha:iroha2-dev Apr 28, 2022
@s8sato s8sato mentioned this pull request Apr 29, 2022
mversic pushed a commit to mversic/iroha that referenced this pull request May 2, 2022
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 4, 2022
appetrosyan pushed a commit that referenced this pull request May 5, 2022
Signed-off-by: s8sato <[email protected]>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
appetrosyan pushed a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
mversic pushed a commit to mversic/iroha that referenced this pull request May 13, 2022
mversic pushed a commit to mversic/iroha that referenced this pull request May 13, 2022
mversic pushed a commit to mversic/iroha that referenced this pull request May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants