Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] #2050: Add role-related queries. #2126

Merged
merged 4 commits into from
May 5, 2022
Merged

[feature] #2050: Add role-related queries. #2126

merged 4 commits into from
May 5, 2022
+416 −64

Conversation

appetrosyan
Copy link
Contributor

@appetrosyan appetrosyan commented Apr 20, 2022 •
edited
Loading

Signed-off-by: Aleksandr Petrosyan [email protected]

Description of the Change

Add a few more queries.

Issue

Closes #2050
Closes #1986

Benefits

Can now query both roles and triggers.

Possible Drawbacks

None

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Apr 20, 2022
@appetrosyan appetrosyan mentioned this pull request Apr 26, 2022
Closed
@appetrosyan appetrosyan force-pushed the i2-queries branch 5 times, most recently from b80093b to 7654a69 Compare April 28, 2022 07:07
@appetrosyan appetrosyan marked this pull request as ready for review April 28, 2022 13:50
mversic
mversic previously approved these changes May 2, 2022
View reviewed changes
mversic
mversic previously approved these changes May 4, 2022
View reviewed changes
@s8sato s8sato self-assigned this May 4, 2022
@appetrosyan appetrosyan assigned mversic and s8sato and unassigned s8sato May 4, 2022
@appetrosyan appetrosyan requested review from s8sato and mversic May 5, 2022 07:02
@appetrosyan appetrosyan enabled auto-merge (squash) May 5, 2022 08:40
@appetrosyan appetrosyan requested a review from s8sato May 5, 2022 08:45
mversic
mversic reviewed May 5, 2022
View reviewed changes
CHANGELOG.rst Outdated
@@ -761,3 +761,4 @@ Other
``proposal_creation_timeout``.
Update sample config file to have not deprecated DB connection params.

Error: Keyboard Interrupt. Bailing out.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this belong in a changelog?

@mversic mversic self-requested a review May 5, 2022 08:50
mversic
mversic previously approved these changes May 5, 2022
View reviewed changes
@appetrosyan appetrosyan requested a review from mversic May 5, 2022 08:52
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #2126 (9915458) into iroha2-dev (8df1b4c) will increase coverage by 0.12%.
The diff coverage is 15.34%.

@@              Coverage Diff               @@
##           iroha2-dev    #2126      +/-   ##
==============================================
+ Coverage       76.61%   76.74%   +0.12%     
==============================================
  Files             182      182              
  Lines           25916    26058     +142     
==============================================
+ Hits            19856    19997     +141     
- Misses           6060     6061       +1
Impacted Files Coverage Δ
cli/src/torii/routing.rs 82.29% <ø> (ø)
client/src/client.rs 89.21% <ø> (ø)
core/src/smartcontracts/isi/asset.rs 59.04% <ø> (ø)
core/src/smartcontracts/isi/query.rs 82.62% <0.00%> (-1.99%) ⬇️
core/src/smartcontracts/isi/triggers.rs 27.50% <0.00%> (-5.84%) ⬇️
core/src/smartcontracts/isi/world.rs 36.78% <0.00%> (-1.78%) ⬇️
core/src/triggers.rs 40.90% <0.00%> (-2.47%) ⬇️
...issions_validators/src/private_blockchain/query.rs 4.51% <0.00%> (-0.92%) ⬇️
data_model/src/query.rs 31.30% <9.61%> (-2.77%) ⬇️
data_model/src/trigger.rs 57.53% <22.22%> (-4.11%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8df1b4c...9915458. Read the comment docs.

@appetrosyan appetrosyan merged commit 322afe8 into hyperledger-iroha:iroha2-dev May 5, 2022
appetrosyan added a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
@appetrosyan
[feature] hyperledger-iroha#2050: Add role-related queries. (hyperled…
792de98 
…ger-iroha#2126)

Signed-off-by: Aleksandr Petrosyan <[email protected]>
appetrosyan added a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
@appetrosyan
[feature] hyperledger-iroha#2050: Add role-related queries. (hyperled…
ad21fc8 
…ger-iroha#2126)

Signed-off-by: Aleksandr Petrosyan <[email protected]>
appetrosyan added a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
@appetrosyan
[feature] hyperledger-iroha#2050: Add role-related queries. (hyperled…
83c251a 
…ger-iroha#2126)

Signed-off-by: Aleksandr Petrosyan <[email protected]>
appetrosyan added a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
@appetrosyan
[feature] hyperledger-iroha#2050: Add role-related queries. (hyperled…
f84f6e1 
…ger-iroha#2126)

Signed-off-by: Aleksandr Petrosyan <[email protected]>
appetrosyan added a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
@appetrosyan
[feature] hyperledger-iroha#2050: Add role-related queries. (hyperled…
a95027a 
…ger-iroha#2126)

Signed-off-by: Aleksandr Petrosyan <[email protected]>
appetrosyan added a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
@appetrosyan
[feature] hyperledger-iroha#2050: Add role-related queries. (hyperled…
114c8b6 
…ger-iroha#2126)

Signed-off-by: Aleksandr Petrosyan <[email protected]>
appetrosyan added a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
@appetrosyan
[feature] hyperledger-iroha#2050: Add role-related queries. (hyperled…
dc29bb6 
…ger-iroha#2126)

Signed-off-by: Aleksandr Petrosyan <[email protected]>
appetrosyan added a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
@appetrosyan
[feature] hyperledger-iroha#2050: Add role-related queries. (hyperled…
2689064 
…ger-iroha#2126)

Signed-off-by: Aleksandr Petrosyan <[email protected]>
appetrosyan added a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
@appetrosyan
[feature] hyperledger-iroha#2050: Add role-related queries. (hyperled…
e36d15e 
…ger-iroha#2126)

Signed-off-by: Aleksandr Petrosyan <[email protected]>
appetrosyan added a commit to appetrosyan/iroha that referenced this pull request May 12, 2022
@appetrosyan
[feature] hyperledger-iroha#2050: Add role-related queries. (hyperled…
c4c84b5 
…ger-iroha#2126)

Signed-off-by: Aleksandr Petrosyan <[email protected]>
mversic pushed a commit to mversic/iroha that referenced this pull request May 13, 2022
@appetrosyan @mversic
[feature] hyperledger-iroha#2050: Add role-related queries. (hyperled…
4f14328 
…ger-iroha#2126)

Signed-off-by: Aleksandr Petrosyan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s8sato s8sato s8sato approved these changes

@SamHSmith SamHSmith SamHSmith approved these changes

@Arjentix Arjentix Awaiting requested review from Arjentix

@QuentinI QuentinI Awaiting requested review from QuentinI

@outoftardis outoftardis Awaiting requested review from outoftardis

@mversic mversic Awaiting requested review from mversic

Assignees

@mversic mversic

@s8sato s8sato

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@appetrosyan @SamHSmith @mversic @s8sato