[schema] #2114: Sorted collections support in schemas #2115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
iroha2-dev
mversic
commented
Apr 17, 2022
mversic
commented
Apr 17, 2022
mversic
changed the title
mversic
commented
Apr 17, 2022
mversic
force-pushed
the
schema_rework
branch
5 times, most recently
from
de84c1b
to
a5fa918
Compare
mversic
commented
Apr 19, 2022
mversic
force-pushed
the
schema_rework
branch
4 times, most recently
from
5a21609
to
c54c2a9
Compare
s8sato
previously approved these changes
Apr 20, 2022
Signed-off-by: Marin Veršić <[email protected]>
s8sato
approved these changes
Apr 20, 2022
appetrosyan
approved these changes
Apr 20, 2022
mversic
added a commit
to mversic/iroha
that referenced
this pull request
May 2, 2022
hyperledger-iroha#2115) Signed-off-by: Marin Veršić <[email protected]>
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 4, 2022
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
hyperledger-iroha#2115) Signed-off-by: Marin Veršić <[email protected]>
mversic
added a commit
to mversic/iroha
that referenced
this pull request
May 13, 2022
hyperledger-iroha#2115) Signed-off-by: Marin Veršić <[email protected]>
mversic
added a commit
to mversic/iroha
that referenced
this pull request
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marin Veršić [email protected]
Description of the Change
Considering that we make abundant use of digital signatures, serialized formats of our internal structures must have a defined ordering, e.g.
BTreeMapmust be represented as a sorted vector of tuples. While it may be possible that there will beBTreeMaps that won't be part of a structure that is signed(and require a defined ordering of tuples), I find it to be quite unlikely and don't think it worth to support such exception.Issue
Closes #2114
Benefits
Possible Drawbacks
Usage Examples or Tests [optional]
Alternate Designs [optional]