[refactor] #2109: Make integration::events::pipeline test stable
#2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
iroha2-dev
s8sato
changed the title
integration::events::pipeline testintegration::events::pipeline test
s8sato
changed the title
integration::events::pipeline test
s8sato
changed the title
integration::events::pipeline test stable
s8sato
commented
Apr 16, 2022
|
|
||
| for submitting_peer in 0..PEER_COUNT { |
There was a problem hiding this comment.
I don't think n:n transactions should be tested. 1:n should be enough
There was a problem hiding this comment.
We can always add n:n tests back in. With that said, I'd prefer adding a property-based suite.
appetrosyan
previously approved these changes
Apr 18, 2022
mversic
previously approved these changes
Apr 19, 2022
Signed-off-by: s8sato <[email protected]>
appetrosyan
approved these changes
Apr 20, 2022
mversic
approved these changes
Apr 20, 2022
mversic
pushed a commit
to mversic/iroha
that referenced
this pull request
May 2, 2022
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 4, 2022
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
mversic
pushed a commit
to mversic/iroha
that referenced
this pull request
May 13, 2022
mversic
pushed a commit
to mversic/iroha
that referenced
this pull request
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Refactored.
Issue
integration::events::pipelinetest stable #2109Benefits
Possible Drawbacks
None