Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dops 1651/enable fork build #2046

Merged
merged 132 commits into from
Apr 18, 2022
Merged

Conversation

safinsaf
Copy link
Contributor

@safinsaf safinsaf commented Mar 31, 2022

Description of the Change

We had a problem with building and testing images from forks, they were failing because of lack of secrets
This PR creates another workflow called build-iroha1-fork explicitly for pull requests from forks. It allows to build the code only after approve from maintainers
Permission scopes are decreased in new workflow

Issue

Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

Signed-off-by: safinsaf <[email protected]>
Signed-off-by: safinsaf <[email protected]>
Signed-off-by: safinsaf <[email protected]>
Signed-off-by: safinsaf <[email protected]>
Signed-off-by: safinsaf <[email protected]>
Signed-off-by: safinsaf <[email protected]>
Signed-off-by: safinsaf <[email protected]>
Signed-off-by: safinsaf <[email protected]>
@safinsaf safinsaf closed this Apr 1, 2022
Signed-off-by: safinsaf <[email protected]>
Signed-off-by: safinsaf <[email protected]>
Signed-off-by: safinsaf <[email protected]>
Signed-off-by: safinsaf <[email protected]>
Signed-off-by: safinsaf <[email protected]>
Signed-off-by: safinsaf <[email protected]>
Signed-off-by: safinsaf <[email protected]>
Signed-off-by: safinsaf <[email protected]>
Signed-off-by: safinsaf <[email protected]>
Signed-off-by: safinsaf <[email protected]>
Signed-off-by: safinsaf <[email protected]>
Signed-off-by: safinsaf <[email protected]>
Signed-off-by: safinsaf <[email protected]>
Signed-off-by: safinsaf <[email protected]>
Signed-off-by: safinsaf <[email protected]>
Signed-off-by: safinsaf <[email protected]>
Signed-off-by: safinsaf <[email protected]>
Signed-off-by: safinsaf <[email protected]>
Signed-off-by: safinsaf <[email protected]>
Signed-off-by: safinsaf <[email protected]>
Signed-off-by: safinsaf <[email protected]>
Signed-off-by: safinsaf <[email protected]>
Signed-off-by: safinsaf <[email protected]>
@appetrosyan appetrosyan force-pushed the feature/DOPS-1651/enable-fork-build branch from 4126e7d to 429a6ec Compare April 13, 2022 10:39
@safinsaf safinsaf merged commit 60187b2 into main Apr 18, 2022
@safinsaf safinsaf deleted the feature/DOPS-1651/enable-fork-build branch April 18, 2022 08:33
safinsaf added a commit that referenced this pull request May 27, 2022
* Retire inactive maintainers

Last activity:
2019/07/24 06:25:12 issue_comment.update bakhtin
2018/12/11 14:07:33 issue_comment.update grimadas
2019/12/25 14:09:13 repository_vulnerability_alert.resolve igor-egorov
2019/01/16 12:36:58 issue_comment.update l4l
2018/09/25 11:34:38 issue_comment.update laSinteZ
2018/02/16 15:38:38 issue_comment.update luckychess
2018/07/19 16:06:05 issue_comment.destroy muratovv
2019/02/20 10:16:17 issue_comment.update neewy
2018/12/21 14:47:14 issue_comment.destroy nickaleks
2018/05/03 04:59:54 issue_comment.update Solonets
2018/07/10 13:27:31 issue_comment.update stinger112
2018/06/29 18:16:18 issue_comment.update tyvision
2018/03/20 14:42:37 issue_comment.update victordrobny
2018/03/27 10:07:33 issue_comment.update x3medima17
2017/06/28 05:35:19 org.oauth_app_access_requested yannoban

Signed-off-by: Ry Jones <[email protected]>

* Feature/dops 1651/enable fork build (#2046)

* Add new workflow for forks

Signed-off-by: safinsaf <[email protected]>

* Move to self-hosted runners

Signed-off-by: safinsaf <[email protected]>

* Move to self-hosted runners

Signed-off-by: safinsaf <[email protected]>

* Add deploy steps

Signed-off-by: safinsaf <[email protected]>

* Build all

Signed-off-by: safinsaf <[email protected]>

* Run only one workflow

Signed-off-by: safinsaf <[email protected]>

* Run only one workflow

Signed-off-by: safinsaf <[email protected]>

* Skip not-needed jobs

Signed-off-by: safinsaf <[email protected]>

* Add comments to new checks

Signed-off-by: safinsaf <[email protected]>

* Make the new step first

Signed-off-by: safinsaf <[email protected]>

* Do not allow to change iroha-builder Dockerfile

Signed-off-by: safinsaf <[email protected]>

* Do not allow to change iroha Dockerfile

Signed-off-by: safinsaf <[email protected]>

* Debug iroha workflow not running

Signed-off-by: safinsaf <[email protected]>

* Debug iroha workflow not running

Signed-off-by: safinsaf <[email protected]>

* Show all changed files

Signed-off-by: safinsaf <[email protected]>

* Fetch history of commits for diff

Signed-off-by: safinsaf <[email protected]>

* Try checkout base for mode

Signed-off-by: safinsaf <[email protected]>

* Try checkout v3 on head for diff

Signed-off-by: safinsaf <[email protected]>

* Allow use fork point

Signed-off-by: safinsaf <[email protected]>

* Find fork point

Signed-off-by: safinsaf <[email protected]>

* Find fork point

Signed-off-by: safinsaf <[email protected]>

* Fix finding ancestor

Signed-off-by: safinsaf <[email protected]>

* Try to remove variable in setting new origin

Signed-off-by: safinsaf <[email protected]>

* Fix finding ancestor

Signed-off-by: safinsaf <[email protected]>

* Fix output

Signed-off-by: safinsaf <[email protected]>

* Try fix base origin

Signed-off-by: safinsaf <[email protected]>

* Try fix base origin

Signed-off-by: safinsaf <[email protected]>

* Try fix base origin

Signed-off-by: safinsaf <[email protected]>

* Try fix base origin

Signed-off-by: safinsaf <[email protected]>

* Try fix base origin

Signed-off-by: safinsaf <[email protected]>

* Try fix base origin

Signed-off-by: safinsaf <[email protected]>

* Use export for setting output

Signed-off-by: safinsaf <[email protected]>

* Try saving to file

Signed-off-by: safinsaf <[email protected]>

* Try saving to file

Signed-off-by: safinsaf <[email protected]>

* Try saving to file

Signed-off-by: safinsaf <[email protected]>

* Try saving to file

Signed-off-by: safinsaf <[email protected]>

* Try saving to file

Signed-off-by: safinsaf <[email protected]>

* Try saving to file

Signed-off-by: safinsaf <[email protected]>

* Debug using hardcoded values

Signed-off-by: safinsaf <[email protected]>

* Debug using hardcoded values

Signed-off-by: safinsaf <[email protected]>

* Debug using hardcoded values

Signed-off-by: safinsaf <[email protected]>

* Debug using hardcoded values

Signed-off-by: safinsaf <[email protected]>

* Debug using hardcoded values

Signed-off-by: safinsaf <[email protected]>

* Try other action

Signed-off-by: safinsaf <[email protected]>

* Try other action

Signed-off-by: safinsaf <[email protected]>

* Try other action

Signed-off-by: safinsaf <[email protected]>

* Try other action

Signed-off-by: safinsaf <[email protected]>

* Try other action

Signed-off-by: safinsaf <[email protected]>

* Try other action

Signed-off-by: safinsaf <[email protected]>

* Add comments, replace some anchors

Signed-off-by: safinsaf <[email protected]>

* Remove non-needed job

Signed-off-by: safinsaf <[email protected]>

* Add permissions

Signed-off-by: safinsaf <[email protected]>

* Fix permissions

Signed-off-by: safinsaf <[email protected]>

* Set none to deployments

Signed-off-by: safinsaf <[email protected]>

* Update comments, remove odd steps

Signed-off-by: safinsaf <[email protected]>

* Not allow changing scripts used in dockerfile

Signed-off-by: safinsaf <[email protected]>

* Add new filters

Signed-off-by: safinsaf <[email protected]>

* Debug new filters

Signed-off-by: safinsaf <[email protected]>

* Debug new filters

Signed-off-by: safinsaf <[email protected]>

* Debug new filters

Signed-off-by: safinsaf <[email protected]>

* Refactor to run only by comment

Signed-off-by: safinsaf <[email protected]>

* Refactor to run only by comment

Signed-off-by: safinsaf <[email protected]>

* Refactor to run only by comment

Signed-off-by: safinsaf <[email protected]>

* Try environments

Signed-off-by: safinsaf <[email protected]>

* Add new workflow for forks

Signed-off-by: safinsaf <[email protected]>

* Move to self-hosted runners

Signed-off-by: safinsaf <[email protected]>

* Move to self-hosted runners

Signed-off-by: safinsaf <[email protected]>

* Add deploy steps

Signed-off-by: safinsaf <[email protected]>

* Build all

Signed-off-by: safinsaf <[email protected]>

* Run only one workflow

Signed-off-by: safinsaf <[email protected]>

* Run only one workflow

Signed-off-by: safinsaf <[email protected]>

* Skip not-needed jobs

Signed-off-by: safinsaf <[email protected]>

* Add comments to new checks

Signed-off-by: safinsaf <[email protected]>

* Make the new step first

Signed-off-by: safinsaf <[email protected]>

* Do not allow to change iroha-builder Dockerfile

Signed-off-by: safinsaf <[email protected]>

* Do not allow to change iroha Dockerfile

Signed-off-by: safinsaf <[email protected]>

* Debug iroha workflow not running

Signed-off-by: safinsaf <[email protected]>

* Debug iroha workflow not running

Signed-off-by: safinsaf <[email protected]>

* Show all changed files

Signed-off-by: safinsaf <[email protected]>

* Fetch history of commits for diff

Signed-off-by: safinsaf <[email protected]>

* Try checkout base for mode

Signed-off-by: safinsaf <[email protected]>

* Try checkout v3 on head for diff

Signed-off-by: safinsaf <[email protected]>

* Allow use fork point

Signed-off-by: safinsaf <[email protected]>

* Find fork point

Signed-off-by: safinsaf <[email protected]>

* Find fork point

Signed-off-by: safinsaf <[email protected]>

* Fix finding ancestor

Signed-off-by: safinsaf <[email protected]>

* Try to remove variable in setting new origin

Signed-off-by: safinsaf <[email protected]>

* Fix finding ancestor

Signed-off-by: safinsaf <[email protected]>

* Fix output

Signed-off-by: safinsaf <[email protected]>

* Try fix base origin

Signed-off-by: safinsaf <[email protected]>

* Try fix base origin

Signed-off-by: safinsaf <[email protected]>

* Try fix base origin

Signed-off-by: safinsaf <[email protected]>

* Try fix base origin

Signed-off-by: safinsaf <[email protected]>

* Try fix base origin

Signed-off-by: safinsaf <[email protected]>

* Try fix base origin

Signed-off-by: safinsaf <[email protected]>

* Use export for setting output

Signed-off-by: safinsaf <[email protected]>

* Try saving to file

Signed-off-by: safinsaf <[email protected]>

* Try saving to file

Signed-off-by: safinsaf <[email protected]>

* Try saving to file

Signed-off-by: safinsaf <[email protected]>

* Try saving to file

Signed-off-by: safinsaf <[email protected]>

* Try saving to file

Signed-off-by: safinsaf <[email protected]>

* Try saving to file

Signed-off-by: safinsaf <[email protected]>

* Debug using hardcoded values

Signed-off-by: safinsaf <[email protected]>

* Debug using hardcoded values

Signed-off-by: safinsaf <[email protected]>

* Debug using hardcoded values

Signed-off-by: safinsaf <[email protected]>

* Debug using hardcoded values

Signed-off-by: safinsaf <[email protected]>

* Debug using hardcoded values

Signed-off-by: safinsaf <[email protected]>

* Try other action

Signed-off-by: safinsaf <[email protected]>

* Try other action

Signed-off-by: safinsaf <[email protected]>

* Try other action

Signed-off-by: safinsaf <[email protected]>

* Try other action

Signed-off-by: safinsaf <[email protected]>

* Try other action

Signed-off-by: safinsaf <[email protected]>

* Try other action

Signed-off-by: safinsaf <[email protected]>

* Add comments, replace some anchors

Signed-off-by: safinsaf <[email protected]>

* Remove non-needed job

Signed-off-by: safinsaf <[email protected]>

* Add permissions

Signed-off-by: safinsaf <[email protected]>

* Fix permissions

Signed-off-by: safinsaf <[email protected]>

* Set none to deployments

Signed-off-by: safinsaf <[email protected]>

* Update comments, remove odd steps

Signed-off-by: safinsaf <[email protected]>

* Not allow changing scripts used in dockerfile

Signed-off-by: safinsaf <[email protected]>

* Add new filters

Signed-off-by: safinsaf <[email protected]>

* Debug new filters

Signed-off-by: safinsaf <[email protected]>

* Debug new filters

Signed-off-by: safinsaf <[email protected]>

* Debug new filters

Signed-off-by: safinsaf <[email protected]>

* Refactor to run only by comment

Signed-off-by: safinsaf <[email protected]>

* Refactor to run only by comment

Signed-off-by: safinsaf <[email protected]>

* Refactor to run only by comment

Signed-off-by: safinsaf <[email protected]>

* Try environments

Signed-off-by: safinsaf <[email protected]>

* Add require review to iroha-builder and prepare-env

Signed-off-by: safinsaf <[email protected]>

* Update workflow Readme, update comments, remove odd branches, prepare pr for merge

Signed-off-by: safinsaf <[email protected]>

* Change refs to commits in fork workflow

Signed-off-by: safinsaf <[email protected]>

* Test checkout with  hashes

Signed-off-by: safinsaf <[email protected]>

* Remove fix branch

Signed-off-by: safinsaf <[email protected]>

* Remove running build from comment

Signed-off-by: safinsaf <[email protected]>

* Fix potential injection in contexts log

Signed-off-by: safinsaf <[email protected]>

* Try echo instead of cat

Signed-off-by: safinsaf <[email protected]>

* Try jq instead of echo

Signed-off-by: safinsaf <[email protected]>

* Restrict changing dependency script from forks

Signed-off-by: safinsaf <[email protected]>

* Add read only permissions to all jobs that fo not deploy anything

Signed-off-by: safinsaf <[email protected]>

* Add work branch to workflow

Signed-off-by: safinsaf <[email protected]>

* Remove test branch

Signed-off-by: safinsaf <[email protected]>

* Bump protobuf from 3.5.1 to 3.15.0 in /docs/source

Bumps [protobuf](https://github.com/protocolbuffers/protobuf) from 3.5.1 to 3.15.0.
- [Release notes](https://github.com/protocolbuffers/protobuf/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/master/generate_changelog.py)
- [Commits](protocolbuffers/protobuf@v3.5.1...v3.15.0)

---
updated-dependencies:
- dependency-name: protobuf
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: Alexander Lednev <[email protected]>
Co-authored-by: Ry Jones <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants