Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] #1621: Introduce By Call Triggers #2006

Merged
merged 13 commits into from
Mar 28, 2022

Conversation

Arjentix
Copy link
Contributor

Description of the Change

  • Added new ExecuteTrigger ISI
  • Added new event and filter: ExecuteTriggerEvent and ExecuteTriggerEventFilter
  • Changed WSV so that every clone stores its own copy of events. No reference counting anymore
  • Added some integration tests for a new instruction
  • Opened Fix listen_for_events() in Client #2005

Issue

Closes #1621

Benefits

Now we can execute trigger by ISI call

Possible Drawbacks

Can't see any

Usage Examples or Tests

See client/test/integration/triggers/by_call_trigger.rs

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Mar 24, 2022
@Arjentix Arjentix changed the title Introduce By Call Triggers [feature] #1621: Introduce By Call Triggers Mar 24, 2022
@Arjentix Arjentix added the Enhancement New feature or request label Mar 24, 2022
@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #2006 (5a93cb1) into iroha2-dev (f58992e) will decrease coverage by 0.32%.
The diff coverage is 94.61%.

@@              Coverage Diff               @@
##           iroha2-dev    #2006      +/-   ##
==============================================
- Coverage       77.77%   77.45%   -0.33%     
==============================================
  Files             174      176       +2     
  Lines           23797    23951     +154     
==============================================
+ Hits            18509    18552      +43     
- Misses           5288     5399     +111     
Impacted Files Coverage Δ
data_model/src/transaction.rs 66.66% <0.00%> (-0.23%) ⬇️
data_model/src/events/execute_trigger.rs 77.77% <77.77%> (ø)
...ient/tests/integration/triggers/by_call_trigger.rs 97.84% <97.84%> (ø)
client/tests/integration/triggers/time_trigger.rs 97.22% <100.00%> (ø)
core/src/smartcontracts/isi/mod.rs 74.66% <100.00%> (+0.11%) ⬆️
core/src/smartcontracts/isi/permissions.rs 76.04% <100.00%> (ø)
core/src/smartcontracts/isi/triggers.rs 29.03% <100.00%> (+2.36%) ⬆️
core/src/wsv.rs 91.54% <100.00%> (+0.39%) ⬆️
data_model/src/events/mod.rs 49.09% <100.00%> (+1.92%) ⬆️
data_model/src/isi.rs 82.28% <100.00%> (+0.49%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f58992e...5a93cb1. Read the comment docs.

core/src/wsv.rs Show resolved Hide resolved
core/src/wsv.rs Outdated Show resolved Hide resolved
s8sato
s8sato previously approved these changes Mar 25, 2022
appetrosyan
appetrosyan previously approved these changes Mar 25, 2022
@appetrosyan appetrosyan requested a review from s8sato March 25, 2022 18:02
@Arjentix Arjentix merged commit eaa2b7e into hyperledger-iroha:iroha2-dev Mar 28, 2022
@Arjentix Arjentix deleted the by_call_triggers branch March 28, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants