-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] #1621: Introduce By Call Triggers #2006
Merged
Arjentix
merged 13 commits into
hyperledger-iroha:iroha2-dev
from
Arjentix:by_call_triggers
Mar 28, 2022
Merged
[feature] #1621: Introduce By Call Triggers #2006
Arjentix
merged 13 commits into
hyperledger-iroha:iroha2-dev
from
Arjentix:by_call_triggers
Mar 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
label
Mar 24, 2022
Arjentix
changed the title
Introduce By Call Triggers
[feature] #1621: Introduce By Call Triggers
Mar 24, 2022
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #2006 +/- ##
==============================================
- Coverage 77.77% 77.45% -0.33%
==============================================
Files 174 176 +2
Lines 23797 23951 +154
==============================================
+ Hits 18509 18552 +43
- Misses 5288 5399 +111
Continue to review full report at Codecov.
|
s8sato
reviewed
Mar 25, 2022
appetrosyan
reviewed
Mar 25, 2022
s8sato
previously approved these changes
Mar 25, 2022
appetrosyan
previously approved these changes
Mar 25, 2022
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
Arjentix
force-pushed
the
by_call_triggers
branch
from
March 25, 2022 14:40
9f0a659
to
5a93cb1
Compare
appetrosyan
approved these changes
Mar 25, 2022
s8sato
approved these changes
Mar 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
ExecuteTrigger
ISIExecuteTriggerEvent
andExecuteTriggerEventFilter
WSV
so that every clone stores its own copy of events. No reference counting anymorelisten_for_events()
inClient
#2005Issue
Closes #1621
Benefits
Now we can execute trigger by ISI call
Possible Drawbacks
Can't see any
Usage Examples or Tests
See
client/test/integration/triggers/by_call_trigger.rs