[discussion] Remove tokio-console feature from iroha_config
#4323
Assignees
Labels
config-changes
Changes in configuration and start up of the Iroha
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
question
Further information is requested
UI
Something about the interface
Comments
0x009922
added
question
0x009922
added a commit
to 0x009922/iroha
that referenced
this issue
Mar 15, 2024
…eature Signed-off-by: Dmitry Balashov <[email protected]>
0x009922
added a commit
to 0x009922/iroha
that referenced
this issue
Mar 21, 2024
…eature Signed-off-by: Dmitry Balashov <[email protected]>
4 tasks
0x009922
added a commit
to 0x009922/iroha
that referenced
this issue
Mar 22, 2024
…eature Signed-off-by: Dmitry Balashov <[email protected]>
0x009922
added a commit
that referenced
this issue
Mar 26, 2024
…uration (#4377) * [chore] #4323: remove `iroha_config/tokio-console` feature Signed-off-by: Dmitry Balashov <[email protected]> * [chore]: format Signed-off-by: Dmitry Balashov <[email protected]> * [refactor]: re-arrange telemetry features - remove `tokio_console_address` configuration - leverage default ENVs for tokio console config - `iroha_logger/tokio-console` feature fully controls whether it is enabled - refactoring chores Signed-off-by: Dmitry Balashov <[email protected]> * [test]: fixes Signed-off-by: Dmitry Balashov <[email protected]> * [chore]: repair `Cargo.toml` Signed-off-by: Dmitry Balashov <[email protected]> * [chore]: repair `Cargo.toml` (how often should I?) Signed-off-by: Dmitry Balashov <[email protected]> * [refactor]: `[telemetry.dev]` to `[dev_telemetry]` Signed-off-by: Dmitry Balashov <[email protected]> * [build]: fix Iroha build with `--no-default-features` Signed-off-by: Dmitry Balashov <[email protected]> * [refactor]: move args tests to `lib.rs` Signed-off-by: Dmitry Balashov <[email protected]> * [feature]: add cargo features into `iroha --version` Signed-off-by: Dmitry Balashov <[email protected]> * [feature]: improve logging a bit Signed-off-by: Dmitry Balashov <[email protected]> * [feature]: `mkdir -r` for `dev_telemetry.out_file` Signed-off-by: Dmitry Balashov <[email protected]> * [feature]: improve validation of paths in config Signed-off-by: Dmitry Balashov <[email protected]> * [fix]: add `\n` separator to file telemetry logs Signed-off-by: Dmitry Balashov <[email protected]> * [chore]: update snapshot logs Signed-off-by: Dmitry Balashov <[email protected]> * [fix]: use `write_all` again Signed-off-by: Dmitry Balashov <[email protected]> * [fix]: disable `genesis.file` validation (#4383) Signed-off-by: Dmitry Balashov <[email protected]> * [test]: remove telemetry features from integration tests Signed-off-by: Dmitry Balashov <[email protected]> * [chore]: revert "WSV" logs Signed-off-by: Dmitry Balashov <[email protected]> --------- Signed-off-by: Dmitry Balashov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
iroha_configcrate hastokio-consolefeature, which enableslogger.tokio_console_addressconfiguration parameter.It introduces some dev issues:
cargo testswithout this feature enables, config snapshot tests will fail, and their feature-gating will be quite... ambiguous and cumbersome, I can imagine.https://github.com/hyperledger/iroha/blob/964476722e2a219becaacdb3676ca058ec5748cd/logger/src/lib.rs#L85-L90
A benefit of having this feature is that... allowing to compile Iroha without knowing that this field even exists?
From the UI standpoint, I think, even in this case it would be better to have
logger.tokio_console_addressfield in the config anyway, but if the actual feature is disabled, Iroha can issue a warning. This is more user-friendly, simpler in the code, and has minimal overhead.The text was updated successfully, but these errors were encountered: