This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Fix thread safe issue in status streaming #1991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Konstantin Munichev <[email protected]>
Akvinikym
approved these changes
Dec 25, 2018
lebdron
approved these changes
Dec 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Pull request replaces static local variable in to a generic local one in status streaming handler to prevent races on it (actually, initialisation by itself is safe but % operator is not).
Benefits
Clients can now perform streaming status requests without unknown status issue (IR-76).
Possible Drawbacks
None.
Usage Examples or Tests
Correctness of fix was tested with help of thread sanitizer. Also instance of irohad is now able to survive under load of 4 clients bombarding it with transactions and streaming status requests on it for at least 30 minutes.