This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Update tx-example.py and blocks-query.py #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 12, 2018 16:56
Signed-off-by: Igor Egorov <[email protected]>
Signed-off-by: Igor Egorov <[email protected]>
Signed-off-by: Igor Egorov <[email protected]>
igor-egorov
added
needs-review
igor-egorov
requested review from
nickaleks,
lebdron and
luckychess
and removed request for
nickaleks
added 2 commits
November 12, 2018 17:25
No need to have separate method for signing blocks queries Signed-off-by: Igor Egorov <[email protected]>
Signed-off-by: Igor Egorov <[email protected]>
luckychess
approved these changes
Nov 13, 2018
| @@ -211,6 +217,28 @@ def query(self, name, counter=1, creator_account=None, created_time=None, **kwar | |||
| internal_query.CopyFrom(message) | |||
| return query_wrapper | |||
|
|
|||
| def blocks_query(self, counter=1, creator_account=None, created_time=None): | |||
There was a problem hiding this comment.
May be just creator_account=self.creator_account, created_time=self.now()? Lines 228-231 could be removed after that.
There was a problem hiding this comment.
Unfortunately, that won't work, since self is not defined at the moment of evaluation.
>>> class A(object):
... def __init__(self):
... self.a = 'abc'
... def x(self, param=self.a):
... print(param)
...
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "<stdin>", line 4, in A
NameError: name 'self' is not defined
There was a problem hiding this comment.
Python was definitely overrated by me.
Signed-off-by: Igor Egorov <[email protected]>
nickaleks
approved these changes
Nov 14, 2018
| .createdTime(current_time()) \ | ||
| .transferAsset("admin@test", "userone@domain", "coin#domain", "Some message", "2.00").build() | ||
| tx = iroha.transaction([ | ||
| iroha.command('TransferAsset', src_account_id='admin@test', dest_account_id='userone@domain', |
There was a problem hiding this comment.
Applied autopep8
added 2 commits
November 15, 2018 12:20
Signed-off-by: Igor Egorov <[email protected]>
Signed-off-by: Igor Egorov <[email protected]>
|
Since those files ( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Igor Egorov [email protected]
Description of the Change
New Iroha lib in Python gets able to query blocks stream.
Examples
tx-example.pyandblocks-query.pyare updated.Benefits
Up to date examples.
Possible Drawbacks
None ?
Usage Examples or Tests