This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Introduce error codes to SFV #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akvinikym <[email protected]>
Signed-off-by: Akvinikym <[email protected]>
Signed-off-by: Akvinikym <[email protected]>
Signed-off-by: Akvinikym <[email protected]>
Signed-off-by: Akvinikym <[email protected]>
Signed-off-by: Akvinikym <[email protected]>
Signed-off-by: Akvinikym <[email protected]>
Signed-off-by: Akvinikym <[email protected]>
:( |
l4l
added
needs-correction
kamilsa
approved these changes
Oct 30, 2018
| @@ -286,9 +286,9 @@ TEST_F(SimulatorTest, RightNumberOfFailedTxs) { | |||
| .transactions(std::vector<shared_model::proto::Transaction>{tx}) | |||
| .build()); | |||
| auto tx_errors = iroha::validation::TransactionsErrors{ | |||
| std::make_pair(validation::CommandError{"SomeCommand", "SomeError", true}, | |||
| std::make_pair(validation::CommandError{"SomeCommand", 1, true}, | |||
There was a problem hiding this comment.
maybe add some number variable to avoid magic number here and upwards in this PR?
There was a problem hiding this comment.
It's covered in IR-1816 as well
l4l
previously requested changes
Oct 30, 2018
| "Transaction %s failed signatures validation with db error: %s", | ||
| transaction.toString(), | ||
| e.what()); | ||
| // TODO [IR-1816] Akvinikym 29.10.18: substitute error code magic number |
There was a problem hiding this comment.
Looks like a suitable thing to do in that pr
There was a problem hiding this comment.
I think, it still needs to be a distinct PR with this task, and definitely not this one, as it's going to touch also PosgtresExecutor and QueryExecutor
Signed-off-by: Akvinikym <[email protected]>
Signed-off-by: Akvinikym <[email protected]>
Signed-off-by: Akvinikym <[email protected]>
l4l
added
needs-review
l4l
approved these changes
Oct 31, 2018
Signed-off-by: Akvinikym <[email protected]>
Signed-off-by: Akvinikym <[email protected]>
Signed-off-by: Akvinikym <[email protected]>
Signed-off-by: Akvinikym <[email protected]>
Signed-off-by: Akvinikym <[email protected]>
Signed-off-by: Akvinikym <[email protected]>
Signed-off-by: Akvinikym <[email protected]>
… feature/stf-vld-err-codes
Akvinikym
changed the base branch from
feature/cmd-exec-err-codes
to
trunk/stf-rsp-err-codes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Step II of introducing stateful validation error codes: now they are brought into StatefulValidator and TemporaryWSV.
Benefits
One more step to error codes.
Possible Drawbacks
None.