Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(test-plugin-ledger-connector-besu): jestify get-block-endpoint #3607

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

krriscode
Copy link

test(connector-besu): migrate get-block-endpoint to Jest

Primary Changes:

packages/cactus-test-plugin-ledger-connector-besu/src/test/typescript/
integration/plugin-validator-besu/get-block-endpoint.test.ts

Fixes: #3500

Signed-off-by: krriscode [email protected]

Migration of get-block-endpoint.ts from tape-promise to Jest. Update tests for improved reliability and performance.

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krriscode Looking good, thank you!

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krriscode Please fix the commit lint check by modifying the git commit message. It looks like you need a line break somewhere to make the lines less than 100 characters each.

If you need any help with the git mechanics involved just let me know and I can help.

image

@krriscode krriscode force-pushed the test-jest-migration-besu-get-block-endpoint_ branch from 0f99b2e to 8bb1296 Compare November 6, 2024 10:53
@krriscode
Copy link
Author

Hi @petermetz,
I have fixed the commit message as you suggested
please review the PR.

Migration of get-block-endpoint.ts from tape-promise to Jest.
Update tests for improved reliability and performance.

Signed-off-by: krriscode <[email protected]>
@petermetz petermetz force-pushed the test-jest-migration-besu-get-block-endpoint_ branch from 8bb1296 to 822ae13 Compare November 7, 2024 15:41
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krriscode Getting closer! Now the commit message is looking good but you are not doing the signoff with the correct name and/or email address. Please see the details here:

https://github.com/hyperledger-cacti/cacti/pull/3607/checks?check_run_id=32664817913

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test(connector-besu): migrate get-block-endpoint test cases from Tap to Jest
3 participants