Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(api-client): jestify default-consortium-provider.test.ts #3513

Conversation

petermetz
Copy link
Contributor

This was the final test case that was still using TAP so now we got to
turn off the tape invocation in the ci completely which is also a performance
gain worth mentioning.

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was the final test case that was still using TAP so now we got to
turn off the tape invocation in the ci completely which is also a performance
gain worth mentioning.

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz force-pushed the test-api-client-jestify-default-consortium-provider-test-case branch from 2989bf5 to 2a68f45 Compare September 9, 2024 16:39
@petermetz petermetz merged commit 6f58699 into hyperledger-cacti:main Sep 9, 2024
146 of 148 checks passed
@petermetz petermetz deleted the test-api-client-jestify-default-consortium-provider-test-case branch September 9, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants