feat(connector-corda): support JVM 17 Cordapps #3387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
requested review from
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Jul 8, 2024
1. The test case was broken due to a number of different issues related to the AIO image build an also the connector image build, but on top of those problems it also had misconfiguration issues where the port number wasn't set to what it should be for the RPC connection that the connector container uses to establish communications with the AIO ledger image. In order to properly verify that this test case is working, a few other pull requests have to be merged first and container images from those sources published as well. In addition to the pull request dependencies we also depend on a permission issue being resolved in the larger GitHub organization itself as well: hyperledger/governance#299 Depends on hyperledger-cacti#3386 Depends on hyperledger-cacti#3387 Signed-off-by: Peter Somogyvari <[email protected]>
5 tasks
outSH
approved these changes
Jul 9, 2024
1. The runner stage of the corda connector JVM image now uses an up to date JRE instead of the very old JDK 8 which the builder stage is still stuck on. 2. This enables the connector to load and use contract .jar files which were built with the newer JDK as well. 3. This is important because we would like to support as wide range of contract/flow invocation use cases as possible and also recently there's been some changes in the Corda official samples repositories where the contracts are being upgraded to JVM 17 as well so this will become more and more relevant as a use-case in the near future. Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
force-pushed
the
feat-connector-corda-support-jvm-17-cordapps
branch
from
23dcf55
to
a94888a
Compare
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Jul 9, 2024
Primary Change: --------------- 1. The test case was broken due to a number of different issues related to the AIO image build an also the connector image build, but on top of those problems it also had misconfiguration issues where the port number wasn't set to what it should be for the RPC connection that the connector container uses to establish communications with the AIO ledger image. Secondary Change(s): --------------------- 1. Fixed 2 bugs in the test tooling package where the port configuration was not randomizing the exposed ports of the corda connector container and the corda test ledger leading to accessibility issues. 2. Also introduced a createJvmInt(...) utility function on the corda connector package which allows the flowdb test case to construct the flow invocation requests with much less manual labor (manual coding). In order to properly verify that this test case is working, a few other pull requests have to be merged first and container images from those sources published as well. In addition to the pull request dependencies we also depend on a permission issue being resolved in the larger GitHub organization itself as well: hyperledger/governance#299 Depends on hyperledger-cacti#3386 Depends on hyperledger-cacti#3387 Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Jul 10, 2024
Primary Change: --------------- 1. The test case was broken due to a number of different issues related to the AIO image build an also the connector image build, but on top of those problems it also had misconfiguration issues where the port number wasn't set to what it should be for the RPC connection that the connector container uses to establish communications with the AIO ledger image. Secondary Change(s): --------------------- 1. Fixed 2 bugs in the test tooling package where the port configuration was not randomizing the exposed ports of the corda connector container and the corda test ledger leading to accessibility issues. 2. Also introduced a createJvmInt(...) utility function on the corda connector package which allows the flowdb test case to construct the flow invocation requests with much less manual labor (manual coding). In order to properly verify that this test case is working, a few other pull requests have to be merged first and container images from those sources published as well. In addition to the pull request dependencies we also depend on a permission issue being resolved in the larger GitHub organization itself as well: hyperledger/governance#299 Depends on hyperledger-cacti#3386 Depends on hyperledger-cacti#3387 Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Jul 10, 2024
Primary Change: --------------- 1. The test case was broken due to a number of different issues related to the AIO image build an also the connector image build, but on top of those problems it also had misconfiguration issues where the port number wasn't set to what it should be for the RPC connection that the connector container uses to establish communications with the AIO ledger image. Secondary Change(s): --------------------- 1. Fixed 2 bugs in the test tooling package where the port configuration was not randomizing the exposed ports of the corda connector container and the corda test ledger leading to accessibility issues. 2. Also introduced a createJvmInt(...) utility function on the corda connector package which allows the flowdb test case to construct the flow invocation requests with much less manual labor (manual coding). In order to properly verify that this test case is working, a few other pull requests have to be merged first and container images from those sources published as well. In addition to the pull request dependencies we also depend on a permission issue being resolved in the larger GitHub organization itself as well: hyperledger/governance#299 Depends on hyperledger-cacti#3386 Depends on hyperledger-cacti#3387 Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
added a commit
that referenced
this pull request
Jul 10, 2024
Primary Change: --------------- 1. The test case was broken due to a number of different issues related to the AIO image build an also the connector image build, but on top of those problems it also had misconfiguration issues where the port number wasn't set to what it should be for the RPC connection that the connector container uses to establish communications with the AIO ledger image. Secondary Change(s): --------------------- 1. Fixed 2 bugs in the test tooling package where the port configuration was not randomizing the exposed ports of the corda connector container and the corda test ledger leading to accessibility issues. 2. Also introduced a createJvmInt(...) utility function on the corda connector package which allows the flowdb test case to construct the flow invocation requests with much less manual labor (manual coding). In order to properly verify that this test case is working, a few other pull requests have to be merged first and container images from those sources published as well. In addition to the pull request dependencies we also depend on a permission issue being resolved in the larger GitHub organization itself as well: hyperledger/governance#299 Depends on #3386 Depends on #3387 Signed-off-by: Peter Somogyvari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
date JRE instead of the very old JDK 8 which the builder stage is still
stuck on.
were built with the newer JDK as well.
contract/flow invocation use cases as possible and also recently there's
been some changes in the Corda official samples repositories where the
contracts are being upgraded to JVM 17 as well so this will become more
and more relevant as a use-case in the near future.
Signed-off-by: Peter Somogyvari [email protected]
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.