Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(weaver): use docker compose v2 #3372

Conversation

jenniferlianne
Copy link

@jenniferlianne jenniferlianne commented Jul 2, 2024

Primary change: Updates the weaver files to use docker compose v2 syntax. docker-compose v1 will be dropped on the github runners shortly.

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@sandeepnRES
Copy link
Contributor

Hi @jenniferlianne Can you update the version of docker compose in docs:
docs/docs/weaver/getting-started/test-network, in all the setup-*.md files, we have prerequisites defined where right now we say use version below 2 for docker-compose. Can you please update that?

@jenniferlianne jenniferlianne force-pushed the update_weaver_to_docker_compose_v2 branch 2 times, most recently from 2ceaca2 to b23c4f5 Compare July 3, 2024 15:22
@jenniferlianne
Copy link
Author

@sandeepnRES I have updated all 10 weaver doc .md files that make reference to the Docker Compose version.

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jenniferlianne LGTM, thank you!

@VRamakrishna
Copy link
Contributor

Just noting that this PR is a replacement for #3358.

Copy link
Contributor

@VRamakrishna VRamakrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jenniferlianne Please undo all changes within weaver/docs/. I've submitted another PR (to be merged today) where I delete that folder entirely as it was already deprecated (moved to the docs folder in the root) last year: https://github.com/hyperledger/cacti/pull/3358.

@jenniferlianne jenniferlianne force-pushed the update_weaver_to_docker_compose_v2 branch from b23c4f5 to 2cf16f3 Compare July 5, 2024 11:00
@jenniferlianne
Copy link
Author

I have removed the changes to weaver/docs as requested by @VRamakrishna.

Primary change:  Updates the weaver files
to use docker compose v2 syntax.  docker-compose
v1 will be dropped on the github runners
shortly.

Signed-off-by: Jennifer Bell <[email protected]>
@petermetz petermetz force-pushed the update_weaver_to_docker_compose_v2 branch from 2cf16f3 to 7c85f25 Compare July 9, 2024 16:05
@petermetz petermetz merged commit c284040 into hyperledger-cacti:main Jul 9, 2024
147 of 150 checks passed
@jenniferlianne jenniferlianne deleted the update_weaver_to_docker_compose_v2 branch July 23, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants