Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector-corda): add JSON classname->JVM class object deserialize #3351

Conversation

petermetz
Copy link
Contributor

  1. This allows the API clients to specify a class name from which the backend
    will retrieve the JVM Class<?> object.
  2. It is very simple under the hood it just uses Class.forName(x)
  3. It is needed to be able to do this because when passing in flow parameters
    sometimes the arguments are Class<?> objects and so this was a feature gap.

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

1. This allows the API clients to specify a class name from which the backend
will retrieve the JVM Class<?> object.
2. It is very simple under the hood it just uses `Class.forName(x)`
3. It is needed to be able to do this because when passing in flow parameters
sometimes the arguments are Class<?> objects and so this was a feature gap.

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz force-pushed the feat-connector-corda-jvm-add-json-jvm-class-deserializer branch from fc660e7 to 7d93bed Compare June 27, 2024 04:41
@petermetz petermetz merged commit 0508f14 into hyperledger-cacti:main Jun 27, 2024
147 of 150 checks passed
@petermetz petermetz deleted the feat-connector-corda-jvm-add-json-jvm-class-deserializer branch June 27, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants