-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(faq): added ipv6 default fix #3313
docs(faq): added ipv6 default fix #3313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jagpreetsinghsasan LGTM with comments.
0f29d70
to
692f3c7
Compare
@petermetz I have updated the faq (yes, indeed the logs were must). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jagpreetsinghsasan Thank you very much for the updates! LGTM
@jagpreetsinghsasan Are you still working on this one? |
692f3c7
to
a3895b0
Compare
a3895b0
to
ea70de3
Compare
@outSH requesting for a re-review for the same |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Primary Changes --------------- 1. Added a new FAQ related to configure script stuck at discovering npm registry due to IPv6 defaults Signed-off-by: jagpreetsinghsasan <[email protected]>
Comit to be reviewed
docs(faq): added ipv6 default fix
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.