Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(plugin-consortium-manual): fix API server CRPC port allocation #3300

Conversation

petermetz
Copy link
Contributor

@petermetz petermetz commented Jun 6, 2024

  1. Also sneaking in a fix for a DCI-Lint failure that was introduced recently
    when we added a new Yarn plugin which then stored its install URL in the
    .yarnrc.yml file and it uses the old git default main branch name and does
    not support the new one so we had to exclude the config file from linting.
    2. Also ensured that the ConnectRPC ports are bound to zero in all tests where the API
    server is being used. This will prevent port conflicts randomly popping up across the
    test suite in the future.
    3. Also removed a few test cases from the taprc file because they were already migrated to
    Jest and therefore tap should not run them as they fail with the Jest syntax.
    4. Also fixing the lack of etherscan API key environment variable in the HTLC coordinator tests.

    Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@petermetz petermetz enabled auto-merge (rebase) June 6, 2024 19:15
@petermetz petermetz requested a review from RafaelAPB June 7, 2024 22:44
@petermetz petermetz force-pushed the test-plugin-consortium-manual-fix-api-server-crpc-port-allocation branch from 3813dba to 7614d64 Compare June 7, 2024 23:50
@petermetz
Copy link
Contributor Author

@simulified What is the problem?

1. Also sneaking in a fix for a DCI-Lint failure that was introduced recently
when we added a new Yarn plugin which then stored its install URL in the
.yarnrc.yml file and it uses the old git default main branch name and does
not support the new one so we had to exclude the config file from linting.
2. Also ensured that the ConnectRPC ports are bound to zero in all tests where the API
server is being used. This will prevent port conflicts randomly popping up across the
test suite in the future.
3. Also removed a few test cases from the taprc file because they were already migrated to
Jest and therefore tap should not run them as they fail with the Jest syntax.
4. Also fixing the lack of etherscan API key environment variable in the HTLC coordinator tests.

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz force-pushed the test-plugin-consortium-manual-fix-api-server-crpc-port-allocation branch from 7614d64 to 5e342ad Compare June 12, 2024 17:47
@petermetz petermetz merged commit 4521d10 into hyperledger-cacti:main Jun 12, 2024
145 of 150 checks passed
@petermetz petermetz deleted the test-plugin-consortium-manual-fix-api-server-crpc-port-allocation branch June 12, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants