-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(connector-stellar): add a deploy contract endpoint #3283
build(connector-stellar): add a deploy contract endpoint #3283
Conversation
7aa73ec
to
c27a031
Compare
c27a031
to
c583129
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fazzatti Initial feedback before I do a detailed review:
- please fix the DCO
- include a CI job (ci.yaml) to execute the test(s)
- include all the information in the commit message not just the pull request description.
c583129
to
d35eab4
Compare
Thank you @petermetz !
I think I've got it right now. I didn't notice it was required to have the written line in the commit directly.
Just as opened the PR for review I thought 'perhaps the CI could've been changed in this change...'. Just did this now and I tried to follow the other examples here. Hope it is within the standard for the CI.
Here I added additional bits when writing the PR and didn't think of going back to add those into the commit too but now I think I did update it correctly! Thanks for the remarks! I appreciate! |
d35eab4
to
8b7d241
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fazzatti You need to add the plugin-ledger-connector-stellar-changed
filter to the outputs of the job as well, not just declare it as a filter. Otherwise it won't be accessible to the other job's if
condition and will always evaluate to false ending up skipping the job.
The outputs are at the top of the job declaration and look like this (and the stellar one is missing)
compute_changed_packages:
outputs:
cmd-api-server-changed: ${{ steps.changes.outputs.cmd-api-server-changed }}
plugin-ledger-connector-polkadot-changed: ${{ steps.changes.outputs.plugin-ledger-connector-polkadot-changed }}
plugin-ledger-connector-aries-changed: ${{ steps.changes.outputs.plugin-ledger-connector-aries-changed }}
plugin-ledger-connector-besu-changed: ${{ steps.changes.outputs.plugin-ledger-connector-besu-changed }}
plugin-ledger-connector-corda-changed: ${{ steps.changes.outputs.plugin-ledger-connector-corda-changed }}
plugin-ledger-connector-fabric-changed: ${{ steps.changes.outputs.plugin-ledger-connector-fabric-changed }}
plugin-ledger-connector-ethereum-changed: ${{ steps.changes.outputs.plugin-ledger-connector-ethereum-changed }}
plugin-ledger-connector-iroha2-changed: ${{ steps.changes.outputs.plugin-ledger-connector-iroha2-changed }}
plugin-ledger-connector-quorum-changed: ${{ steps.changes.outputs.plugin-ledger-connector-quorum-changed }}
plugin-htlc-coordinator-besu-changed: ${{ steps.changes.outputs.plugin-htlc-coordinator-besu-changed }}
test-tooling-changed: ${{ steps.changes.outputs.test-tooling-changed }}
ghcr-corda-all-in-one-obligation-changed: ${{ steps.changes.outputs.ghcr-corda-all-in-one-obligation-changed }}
ghcr-corda-all-in-one-changed: ${{ steps.changes.outputs.ghcr-corda-all-in-one-changed }}
ghcr-dev-container-vscode-changed: ${{ steps.changes.outputs.ghcr-dev-container-vscode-changed }}
8b7d241
to
7c8e047
Compare
Thank you so much @petermetz ! |
@petermetz Just noticed that something else failed at the |
- Add a Stellar Connector plugin following the same pattern as the **Besu Connector plugin**. - Add a deploy contract endpoint to the Stellar Connector plugin. **Initialization remarks:** Supports a network configuration object to define all integration services that seamlessly integrate with the Stellar test ledger within the Cacti test tooling. **Deploy remarks:** The deploy process supports both the compiled smart contract WASM as well as the on-chain WASM hash as inputs. This follows the smart contract deployment design on Soroban (Stellar's smart contract platform). Refer to the Stellar documentation at: https://developers.stellar.org/docs/learn/fundamentals/stellar-data-structures/contracts for further detail on this process. More details can be found in the `README.md` file under the connector root directory. Signed-off-by: Fabricius Zatti <[email protected]>
7c8e047
to
d29f769
Compare
I think it should be ok now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fazzatti You are most welcome, I'm glad we figured it out! Looking good now!
Initialization remarks:
Supports a network configuration object to define all integration services that seamlessly integrate with the Stellar test ledger within the Cacti test tooling.
Deploy remarks:
The deploy process supports both the compiled smart contract WASM as well as the on-chain WASM hash as inputs. This follows the smart contract deployment design on Soroban(Stellar's smart contract platform). Refer to the Stellar documentation for further detail on this process.
More details can be found in the
README.md
file under the connector root directory.Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.