Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ci): only publish artifacts on git version tags of main #3278

Conversation

raynatopedrajeta
Copy link
Contributor

@raynatopedrajeta raynatopedrajeta commented May 22, 2024

Commit to be reviewed


perf(ci): only publish artifacts on git version tags of main

Primary Changes 
----------------
1. Remove auto publishing of container images in all **publish.yaml upon push and maintain automation runs during pull requests

Fixes #2360

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The publishing of artifacts shall happen only upon the creation of a tag. Requesting changes for the same

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raynatopedrajeta
Copy link
Contributor Author

Hello @petermetz ,

Review point has been addressed. Re-requested for review.

FYI @jagpreetsinghsasan

Thanks!
Ren

@jagpreetsinghsasan
Copy link
Contributor

Congratulations @raynatopedrajeta for your first PR to Hyperledger Cacti !
Keep up the good work 🥳

@raynatopedrajeta
Copy link
Contributor Author

Congratulations @raynatopedrajeta for your first PR to Hyperledger Cacti ! Keep up the good work 🥳

Thanks a lot @jagpreetsinghsasan ! Looking forward for more learnings with the team!

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raynatopedrajeta Please resolve the merge conflicts, other than that it should be good to go from my side.

@petermetz
Copy link
Contributor

@jagpreetsinghsasan Were your concerns addressed?

@jagpreetsinghsasan
Copy link
Contributor

@jagpreetsinghsasan Were your concerns addressed?

Yes @petermetz , the diff looks fine now

@petermetz
Copy link
Contributor

@jagpreetsinghsasan OK, thank you.

@raynatopedrajeta Please rebase and resolve the conflicts and then re-request review from both me and @jagpreetsinghsasan and we'll get this merged ASAP.

@raynatopedrajeta
Copy link
Contributor Author

Hello @petermetz and @jagpreetsinghsasan ,
Review changes has been addressed.

Thanks!

@jagpreetsinghsasan
Copy link
Contributor

LGTM. Thanks for a quick rebase, @raynatopedrajeta

@petermetz petermetz dismissed jagpreetsinghsasan’s stale review June 28, 2024 17:17

Jagpreet said the review points have been addressed.

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raynatopedrajeta Oops, one more nit: Please fix the ActionLint check that's been failing:

image

@raynatopedrajeta
Copy link
Contributor Author

Hello @petermetz ,

I have pushed another fix for the action lint. However I can't run the workflows yet since it needs maintainer's approval.

Please let me know if there will be more changes.

Thanks!

Raynato

@jagpreetsinghsasan
Copy link
Contributor

Hello @petermetz ,

I have pushed another fix for the action lint. However I can't run the workflows yet since it needs maintainer's approval.

Please let me know if there will be more changes.

Thanks!

Raynato

Done @raynatopedrajeta !!

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raynatopedrajeta LGTM, thank you for the updates!

Primary Changes
----------------
1. Remove auto publishing of container images in all **publish.yaml
   upon push and maintain automation runs during pull requests

Fixes hyperledger-cacti#2360

Signed-off-by: raynato.c.pedrajeta <[email protected]>
@petermetz petermetz changed the title perf(ci): only publish artifacts on git version tags of main perf(ci): only publish artifacts on git version tags of main Jul 5, 2024
@petermetz petermetz merged commit 66e3139 into hyperledger-cacti:main Jul 5, 2024
151 of 154 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

perf(ci): only publish artifacts on git version tags of main
4 participants