docs(weaver): cleaning up documentation and fixing configuration bugs #3246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VRamakrishna
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
sandeepnRES and
outSH
as code owners
|
FYI, this PR needs to be approved BEFORE #3001 . |
sandeepnRES
reviewed
May 6, 2024
sandeepnRES
reviewed
May 6, 2024
outSH
approved these changes
May 6, 2024
sandeepnRES
approved these changes
May 7, 2024
Fixed workflow bugs that resulted in publishing unnecessary NPM packages. Fixed workflow unit test path for Weaver relay. Fixed sample CorDapp deployment procedure to handle error conditions. Ensured that package.json files for local and remote builds of Weaver packages are consistent. Added graceful error handling logic in corda-simple-application build scripts. Fixed filename reference bugs in several Weaver GitHub Actions. Signed-off-by: VRamakrishna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.