Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector-besu): add gRPC support for operations #3174

Merged

Conversation

petermetz
Copy link
Contributor

  1. The Besu connector now can be reached via the gRPC interface.
  2. The same operations are exposed as via HTTP+SocketIO
  3. gRPC supports bi-directional streaming so the block watching is also
    supported and test coverage verifies that it works.
  4. To see an example of how to use the gRPC client of the Besu connector
    read the source code of the test case that provides the verification that
    the functionality works:
packages/cactus-test-plugin-ledger-connector-besu/src/test/typescript/
integration/grpc-services/connector-besu-grpc-services.test.ts

Depends on #3173

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link

github-actions bot commented Apr 4, 2024

This PR/issue depends on:

@petermetz
Copy link
Contributor Author

@hyperledger/cacti-maintainers Bumping the thread on this one!

@petermetz
Copy link
Contributor Author

@hyperledger/cacti-maintainers Bump!

@petermetz petermetz force-pushed the feat-connector-besu-grpc-support branch from 32a78f6 to 1243798 Compare May 24, 2024 18:42
Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1. The Besu connector now can be reached via the gRPC interface.
2. The same operations are exposed as via HTTP+SocketIO
3. gRPC supports bi-directional streaming so the block watching is also
supported and test coverage verifies that it works.
4. To see an example of how to use the gRPC client of the Besu connector
read the source code of the test case that provides the verification that
the functionality works:
```
packages/cactus-test-plugin-ledger-connector-besu/src/test/typescript/
integration/grpc-services/connector-besu-grpc-services.test.ts
```

Depends on hyperledger-cacti#3173

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz force-pushed the feat-connector-besu-grpc-support branch from 1243798 to 121c031 Compare May 29, 2024 15:49
@petermetz petermetz enabled auto-merge (rebase) May 29, 2024 15:49
@petermetz petermetz merged commit ab676d2 into hyperledger-cacti:main May 29, 2024
137 of 149 checks passed
@petermetz petermetz deleted the feat-connector-besu-grpc-support branch May 29, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants