Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Rafael Belchior as a maintainer #3075

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

petermetz
Copy link
Contributor

  1. The MAINTAINERS.md file was updated with contact details
  2. The CODEOWNERS file was updated so that in addition to the current
    code owners Rafael also has ownership of some of the sub-direcotires where
    he is the most active in terms of contributions.
  3. We welcome Rafael to expand the scope of ownership on packages later
    as we are always looking to get more help with maintaining the code. :-)

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

1. The MAINTAINERS.md file was updated with contact details
2. The CODEOWNERS file was updated so that in addition to the current
code owners Rafael also has ownership of some of the sub-direcotires where
he is the most active in terms of contributions.
3. We welcome Rafael to expand the scope of ownership on packages later
as we are always looking to get more help with maintaining the code. :-)

Signed-off-by: Peter Somogyvari <[email protected]>
Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Welcome @RafaelAPB to the maintainers group !

@petermetz petermetz merged commit 8ff98b3 into hyperledger-cacti:main Mar 12, 2024
129 of 147 checks passed
@petermetz petermetz deleted the docs-maintainers-rafael branch March 12, 2024 06:55
@RafaelAPB
Copy link
Contributor

Thank you folks. Excited to be part of the maintainers team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants