build: upgrade & consolidate @types/node at v18.11.9 - NodeJS typings

[petermetz]

1. The default/suggested NodeJS version we use and recommend is v18 LTS
   but there were a lot of places in the code that still declared v14 and
   v16 both of which are now EOL.
2. This was/is working fine but eventually we'll hit some compiler issue
   where the upgrade will be forced so it's most likely wiser to do this little
   quality of life/housekeeping change now when it's not urgent.

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

• Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
• Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
• Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

• Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
• Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

[outSH]

LGTM, but:

• codegen is failing (I'm not familiar with this error, maybe it's just a flake)
• some fabric tests are failing on go deployment, could you investigate if that's not caused by: https://github.com/hyperledger/cacti/commit/21fd747e37d20e2427ad6e86b6d5d15435fbc660 ?

[petermetz]

LGTM, but:

* codegen is failing (I'm not familiar with this error, maybe it's just a flake)

* some fabric tests are failing on go deployment, could you investigate if that's not caused by: [21fd747](https://github.com/hyperledger/cacti/commit/21fd747e37d20e2427ad6e86b6d5d15435fbc660) ?

@outSH The codegen one is a flake unfortunately I haven't had time to fix yet. It happens because one of the packages declares the openapi generator CLI as a dev dependency which makes yarn default to using that instance of it (e.g. the nested node_modules' instance) instead of the root one and only the root node_modules one gets the warm-up script's pre-downloaded jar (the workaround to prevent the race conditions).

I have a possible fix for this but it requires refactoring all the codegen scripts in all the packages so it'll take some time, in the meantime most of the time if you retry the codegen script (it can be re-tried individually so you don't need to re-trigger the entire ci.yaml workflow) then it usually works right away.

---

For the fabric tests: My guess is that they went broke even before [21fd747] because the older AIO fabric images are all flaky now (they tend go bad over time because of auto-upgrades that we can't control), BUT that's just strictly a guess for now and I'm looking into it.

[petermetz]

@outSH I've submitted a separate PR that should fix or at least drastically reduce the flakiness of the Fabric tests: https://github.com/hyperledger/cacti/pull/3082

My investigation (so far) has concluded that there's no link between the Fabric tests aging out and becoming flaky and this current PR, but of course you never know... :-)