test(test-tooling): fix FabricTestLedger INVALID_ENDORSER_TRANSACTION #3031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreAugusto11
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
* reverts changes of commit 3371772, which seems to be breaking the Fabric Test Ledger Results of further investigation into the root cause done by Peter: 1. The URLs we specify have the `grpcs://` protocol specified meaning that TLS is used for securing the connection. 2. Certificates that are generated by the Fabric-provided boostrap scripts when setting up crypto materials for the ledger are generated with `localhost` as the hostname instead of the IP address of localhost. 3. The C++ gRPC implementation does not support mixing IP addresses and hostnames when it comes to connections that are using TLS, e.g. if the certificate we are using was made out for `localhost` then it won't work for `127.0.0.1` even though technically from our perspective they meaning the same thing (do note however that technically localhost could be set up to resolve to something other than 127.0.0.1 in a DNS server so the difference is meaningful). Source: grpc/grpc#2691 closes hyperledger-cacti#3009 Co-authored-by: Peter Somogyvari <[email protected]> Signed-off-by: André Augusto <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
changed the title
petermetz
approved these changes
Feb 28, 2024
outSH
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which seems to be breaking the Fabric Test Ledger
Results of further investigation into the root cause done by Peter:
grpcs://protocol specified meaning thatTLS is used for securing the connection.
when setting up crypto materials for the ledger are generated with
localhostas the hostname instead of the IP address of localhost.
hostnames when it comes to connections that are using TLS, e.g. if the
certificate we are using was made out for
localhostthen it won't workfor
127.0.0.1even though technically from our perspective they meaningthe same thing (do note however that technically localhost could be set
up to resolve to something other than 127.0.0.1 in a DNS server so the
difference is meaningful).
Source: grpc/grpc#2691
closes #3009
Co-authored-by: Peter Somogyvari [email protected]
Signed-off-by: André Augusto [email protected]
Signed-off-by: Peter Somogyvari [email protected]