Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(connector-besu): migrated lock-contract.test.ts to Jest #2934

Conversation

petermetz
Copy link
Contributor

The relative file path of the test case within the project:
packages/cactus-plugin-ledger-connector-besu/src/test/typescript/
integration/plugin-ledger-connector-besu/lock-contract.test.ts

No functional change of any kind, just refactored the assertions
to match how they were before but now executed by Jest.

[skip ci]

Signed-off-by: Peter Somogyvari [email protected]


Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@petermetz petermetz force-pushed the test-connector-besu-jest-migration-lock-contract-test-case branch from 12bdad6 to 781b53d Compare December 11, 2023 21:18
@petermetz petermetz requested a review from outSH December 11, 2023 21:18
The relative file path of the test case within the project:
packages/cactus-plugin-ledger-connector-besu/src/test/typescript/
integration/plugin-ledger-connector-besu/lock-contract.test.ts

No functional change of any kind, just refactored the assertions
to match how they were before but now executed by Jest.

[skip ci]

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz force-pushed the test-connector-besu-jest-migration-lock-contract-test-case branch from 781b53d to 7e4a271 Compare December 14, 2023 19:17
@petermetz petermetz merged commit 9a96b8e into hyperledger-cacti:main Dec 14, 2023
6 of 7 checks passed
@petermetz petermetz deleted the test-connector-besu-jest-migration-lock-contract-test-case branch December 14, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants