-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(examples/cbdc): fix mismatch of fabric identities #2912
docs(examples/cbdc): fix mismatch of fabric identities #2912
Conversation
86efd6d
to
7c46c08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndreAugusto11 LGTM on the big picture. Please do the following though:
- Delete the package-lock.json - it is redundant with the yarn.lock file
- Update the commit message to contain all the information that you also put in the PR description - I noticed that the
Fixes #????
declaration is missing from the commit message. Other stuff might be missing too, didn't check too thoroughly
* Closes hyperledger-cacti#2817 * Depends on hyperledger-cacti#2912 Signed-off-by: André Augusto <[email protected]>
8429ce0
to
465fca9
Compare
@petermetz Done, thank you! |
* Closes hyperledger-cacti#2817 * Depends on hyperledger-cacti#2912 Signed-off-by: André Augusto <[email protected]>
* Closes hyperledger-cacti#2817 * Depends on hyperledger-cacti#2912 Signed-off-by: André Augusto <[email protected]>
* Closes hyperledger-cacti#2817 * Depends on hyperledger-cacti#2912 Signed-off-by: André Augusto <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndreAugusto11 Thank you for the updates! Sorry to just come up with this one, but there's also the issue that the GUI is crashing when I try to test it locally (not with the GUI container image):
88a1ab2
to
2133675
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* What I believe has been an update to the Fabric SDK has led the application to break due to having the Fabric identities hardcoded (for the Fabric-Ethereum ID mapping). This was first noted in hyperledger-cacti#2739 * An initial fix was deployed in hyperledger-cacti#2802 but only the Mint was changed, which caused other functions to be breaking at the moment (e.g., Escrow) * This commit changes the crypto material files and reverts the workaround in PR hyperledger-cacti#2802 * The crypto material is only used for testing and to show information in the frontend (e.g., requesting the balance of a specific user based on the identity) * For critical operations, access control is being performed by the chaincode by using the call at the begining of the relevant methods Fixes hyperledger-cacti#2914 Signed-off-by: André Augusto <[email protected]>
2133675
to
ff8b93d
Compare
* Closes hyperledger-cacti#2817 * Depends on hyperledger-cacti#2912 Signed-off-by: André Augusto <[email protected]>
* Closes hyperledger-cacti#2817 * Depends on hyperledger-cacti#2912 Signed-off-by: André Augusto <[email protected]>
* Closes #2817 * Depends on #2912 Signed-off-by: André Augusto <[email protected]>
* Closes hyperledger-cacti#2817 * Depends on hyperledger-cacti#2912 Signed-off-by: André Augusto <[email protected]>
Fixes #2914