Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples/cbdc): fix mismatch of fabric identities #2912

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

AndreAugusto11
Copy link
Contributor

@AndreAugusto11 AndreAugusto11 commented Nov 30, 2023

Fixes #2914

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndreAugusto11 LGTM on the big picture. Please do the following though:

  1. Delete the package-lock.json - it is redundant with the yarn.lock file
  2. Update the commit message to contain all the information that you also put in the PR description - I noticed that the Fixes #???? declaration is missing from the commit message. Other stuff might be missing too, didn't check too thoroughly

AndreAugusto11 added a commit to AndreAugusto11/cacti that referenced this pull request Dec 2, 2023
@AndreAugusto11 AndreAugusto11 force-pushed the fix-cbdc-example branch 4 times, most recently from 8429ce0 to 465fca9 Compare December 2, 2023 02:23
@AndreAugusto11
Copy link
Contributor Author

AndreAugusto11 commented Dec 2, 2023

@AndreAugusto11 LGTM on the big picture. Please do the following though:

  1. Delete the package-lock.json - it is redundant with the yarn.lock file
  2. Update the commit message to contain all the information that you also put in the PR description - I noticed that the Fixes #???? declaration is missing from the commit message. Other stuff might be missing too, didn't check too thoroughly

@petermetz Done, thank you!

AndreAugusto11 added a commit to AndreAugusto11/cacti that referenced this pull request Dec 2, 2023
AndreAugusto11 added a commit to AndreAugusto11/cacti that referenced this pull request Dec 2, 2023
AndreAugusto11 added a commit to AndreAugusto11/cacti that referenced this pull request Dec 2, 2023
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndreAugusto11 Thank you for the updates! Sorry to just come up with this one, but there's also the issue that the GUI is crashing when I try to test it locally (not with the GUI container image):

image

@AndreAugusto11 AndreAugusto11 force-pushed the fix-cbdc-example branch 2 times, most recently from 88a1ab2 to 2133675 Compare December 3, 2023 20:35
@petermetz petermetz self-requested a review December 5, 2023 02:11
Copy link
Contributor

@izuru0 izuru0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermetz petermetz enabled auto-merge (rebase) December 5, 2023 03:15
* What I believe has been an update to the Fabric SDK
has led the application to break due to having the Fabric
identities hardcoded (for the Fabric-Ethereum ID mapping).
This was first noted in hyperledger-cacti#2739

* An initial fix was deployed in hyperledger-cacti#2802 but only the Mint
was changed, which caused other functions to be breaking
at the moment (e.g., Escrow)

* This commit changes the crypto material files and reverts
the workaround in PR hyperledger-cacti#2802

* The crypto material is only used for testing and to show
information in the frontend (e.g., requesting the balance
of a specific user based on the identity)

* For critical operations, access control is being
performed by the chaincode by using the call at the
begining of the relevant methods

Fixes hyperledger-cacti#2914

Signed-off-by: André Augusto <[email protected]>
@petermetz petermetz merged commit 6a27b7c into hyperledger-cacti:main Dec 5, 2023
40 of 69 checks passed
AndreAugusto11 added a commit to AndreAugusto11/cacti that referenced this pull request Dec 5, 2023
AndreAugusto11 added a commit to AndreAugusto11/cacti that referenced this pull request Dec 5, 2023
petermetz pushed a commit that referenced this pull request Dec 5, 2023
    * Closes #2817
    * Depends on #2912

Signed-off-by: André Augusto <[email protected]>
sandeepnRES pushed a commit to sandeepnRES/cacti that referenced this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs(examples/cbdc): fix mismatch of fabric identities
3 participants