fix(cmd-api-server): address CVE-2022-25881

[zondervancalvez]

Commit to be reviewed

fix(cmd-api-server): address GHSA-rc47-6667-2j5j

Primary Changes:
Updated the Dockerfile & https-cache-semantics inside the cmd-api-server package

Fixes: https://github.com/hyperledger/cacti/issues/2862

Signed-off-by: zondervancalvez [email protected]
Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

• Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
• Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
• Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

• Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
• Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

[petermetz]

@zondervancalvez http-cache-semantics is a transitive dependency. Making it (in addition to being a transitive dependency) a direct dependency of the cmd-api-server package would not have done anything to prevent the older version still being present in the sub-level node_modules dir (the transitive dependency).

With all that said, we've fixed this problem with the bulk CVE fix PR that was sent in a few months back where we added a forced resolution to the package.json in the root folder.

My guess is that the trivy scan was executed against an outdated version of the packages which still haven't had the forced resolution baked into it.

I'm pretty sure that this will be a duplicate based on the above but let's see with the latest release coming up soon and then you can confirm (or not) if it's a duplicate and close this one accordingly.

[petermetz]

@zondervancalvez Are you still working on this?

[zondervancalvez]

@zondervancalvez Are you still working on this?

Hi @petermetz , I've just updated the PR and no more vulnerabilities were found. Thank you

[petermetz]

@zondervancalvez Alright, the fix with the hardcoded image version is good but the http-cache-semantics change is not doing anything to secure the container image build IMO. Let me quickly update that before we merge and then it's good to go from my side.