Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade lerna-lite to v2.6.0 to fix publish resume bug #2892

Merged

Conversation

petermetz
Copy link
Contributor

  1. Older versions of lerna-lite did not correctly detect package
    registry conflict errors if the error code came back from GHCR
    insteda of npmjs.com. This was blocking some of our release
    processes. With the new version it should be fine.

[skip ci]

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

1. Older versions of lerna-lite did not correctly detect package
registry conflict errors if the error code came back from GHCR
insteda of npmjs.com. This was blocking some of our release
processes. With the new version it should be fine.

[skip ci]

Signed-off-by: Peter Somogyvari <[email protected]>
Copy link
Contributor

@izuru0 izuru0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermetz petermetz merged commit 5a59236 into hyperledger-cacti:main Nov 16, 2023
6 of 7 checks passed
@petermetz petermetz deleted the build-deps-upgrade-lerna-lite-v260 branch November 28, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants