Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(connector-corda): fix various Unresolved reference kotlin compiler errors #2878

Merged
merged 1 commit into from
Nov 14, 2023

Commits on Nov 14, 2023

  1. build(connector-corda): fix various Unresolved reference kotlin compi…

    …ler errors
    
    1. Started overriding a specific template (dataClass.mustache) in the
    main-server sub-package of the corda connector because of issues that
    are further explained here [1] and here [2].
    2. Also had to update generator configuration to specifically exclude
    spring-doc generation because it seems to be broken within the template
    as well: it does not provide updated dependencies for the grandle and
    maven manifests and so the `io.swagger.core.v3:swagger-annotations` package
    was missing and failing the build in a second way.
    3. The example value for the return array of `ListFlowsV1Response` in
    the openapi.json spec file of the corda connector was containing dollar
    signs ($) which ended up being appended to the kotlin code's annotations
    as documentation, but the dollar signs have a special meaning in kotlin
    and lead to syntax errors. Updating the examples to not have dollar signs
    in the openapi.json specification document resulted in fixing this issue.
    4. Also updated the artifact version in the openapi generator configuration
    file. This is just a temporary fix, what we really need is scripts bumping
    this up as part of the automated release process.
    
    [1] OpenAPITools/openapi-generator#8366 (comment)
    [2] OpenAPITools/openapi-generator#17008
    
    Fixes hyperledger-cacti#2662
    
    Signed-off-by: Peter Somogyvari <[email protected]>
    petermetz committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    c582de2 View commit details
    Browse the repository at this point in the history