fix(deps): bulk add missing dependencies - 2023-11-02

[petermetz]

1. Added missing dependencies everywhere to all the packages
2. The exception to the above is test runners and related dependencies.
   You can see the detailed exclusion list in the source code of the script
   itself [1]. We should make these configurable later on as well. For
   reference, this is what the exclusions were declared as when I ran the
   tool in order to then proceed to update the package.json files:

ignorePatterns: [
    // files matching these patterns will be ignored
    "sandbox",
    "dist",
    "bower_components",
    "node_modules"
],
ignoreMatches: [
    // ignore dependencies that matches these globs
    "grunt-*",
    "jest-extended",
    "tape-promise",
    "tape",
    "tap",
    "@ionic-native/*"
],

3. There were instances of missing dependency usages where we did NOT
   have to add the dependencies to package.json files because what we could
   do instead is just import types at development time by using the
   import type { .. } from "..."; syntax of Typescript which means that
   the import is disappeared during transpilation completely. So this is why
   some source code files were also modified and not strictly just package.json
   files.
4. Added a script in the ./tools/custom-check directory to audit the
   entire mono-repo for missing NodeJS dependencies.

We've had at least a dozen packages that were missing production
dependency declarations from their package.json files. The usual suspects
here are packages that are contained by the root node_modules folder
which masks the problem at development time (e.g. the compiler won't
let you know about the missing dependencies).

For a future-proof solution we should add a commit hook or other validation
that runs the custom check that I added [2] here to verify that there are no
missing dependencies in the project

[1] ./tools/custom-checks/check-missing-node-deps.ts
[2] $ yarn tools:check-missing-node-deps

Fixes #2857

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

• Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
• Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
• Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

• Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
• Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

[outSH]

@petermetz Can't give approval on this (or any other PR) because I'm missing permissions to this repo, I think Sato-san mentioned it on discord. Could you look into that in spare moment and give me write access so I can perform the reviews?

[petermetz]

@petermetz Can't give approval on this (or any other PR) because I'm missing permissions to this repo, I think Sato-san mentioned it on discord. Could you look into that in spare moment and give me write access so I can perform the reviews?

@outSH Oops, sorry, we need to add you to the Hyperledger GitHub org and then I can grant you permissions. I can't add you to the GH org myself but I sent in a request to the HL staff to get it done here: hyperledger/governance#177
You should see an email in your inbox soon with an invitation to join the Hyperledger GitHub org and once you accept through the link in there then I can fix the permissions!

[petermetz]

@outSH You should have full permissions now on the repo (admin rights)

[outSH]

@petermetz Thank you!

LGTM